FailedChanges

Summary

  1. Bug 562324 - [11][compiler] ClassFormatError caused by var declaration (details)
  2. Bug 572955 - Compiler warning in jdt.compiler.apt (details)
  3. Bug 570399 - [16][reconciler] canonical record (details)
  4. Bug 572393 - fix Intermittent random junit gerrit failures in jdt.core (details)
  5. Bug 562324 - reverted workaround not neeeded after compiler fix (details)
  6. Bug 572205 - [17][sealed] improved error message for anonymous classes (details)
  7. Bug 572484 - Fix the failing test (details)
  8. Bug 572966 - [test] DOM tests should only be run required levels and (details)
  9. Bug 572976 - Disable "new index" tests (details)
  10. Bug 567171 - fix synchronization issue in DeltaProcessingState (details)
  11. Bug 539685 - Complete freeze when invoking code assist (infinite loop?) (details)
  12. Bug 572393 - cleaned up warnings in test code (details)
  13. Bug 572977 - Update signing urls and update CBI version to 1.3.1 (details)
  14. Bug 539685 - Complete freeze when invoking code assist (infinite loop?) (details)
  15. Bug 573084 - ReadManager uses reflection to ask for availableProcessors (details)
  16. Bug 558530 - Calling an enum constructor with a lambda as parameter (details)
  17. Bug 532366 - Autocompletion not available in Enum constructors (details)
  18. Bug 573088 - [test] testLeaksOnCleanBuild fails sporadically on Gerrit (details)
  19. Bug 548779 - [1.8][complete] eclipse hangs on String Autocompletion (details)
  20. Bug 543617 - [completion] Null expectedType when resolving completions (details)
  21. Bug 572934 - Records - parameter hiding a field warning (details)
Commit 7716c2f065b6c4197c8db0b2e59a974b633eba4a by Stephan Herrmann
Bug 562324 - [11][compiler] ClassFormatError caused by var declaration

regression fix + workaround in our own code

Change-Id: Iea1bc3d40b39d29cc58938e274eed92cf6dce9ce
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179457
Tested-by: Stephan Herrmann <stephan.herrmann@berlin.de>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericsRegressionTest_1_8.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BoundSet.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/Scope.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/LambdaExpression.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/CompilationUnitDeclaration.java
Commit 8b9143d789738bb03bbc2db16f9163c49a54916b by Jay Arthanareeswaran
Bug 572955 - Compiler warning in jdt.compiler.apt

Change-Id: Iede57a7dfce064e37cbb18e42abdb3c582d293c5
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179489
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/util/TestVerifier.java
The file was modifiedorg.eclipse.jdt.compiler.apt/src/org/eclipse/jdt/internal/compiler/apt/model/RecordComponentElementImpl.java
Commit eaa4613ef3c01e6a6f765ff4bdb9a07936a4e9c5 by Manoj Palat
Bug 570399 - [16][reconciler] canonical record
constructor is not found when more constructors are present

Change-Id: Ia59939167a169e58986f181f2266f84f31de7dc4
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178904
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest_16.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/AbstractJavaModelTests.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SyntheticMethodBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ClassFile.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/TypeDeclaration.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ClassScope.java
The file was addedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ReconcilerTests16.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/codegen/CodeStream.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/RecordsRestrictedClassTest.java
Commit 6d25ccd6af6b9ebb2d76fe034394292cedebc2c5 by Andrey Loskutov
Bug 572393 - fix Intermittent random junit gerrit failures in jdt.core

- GenericTypeTest: currentTimeMillis() is not a valid measure on a build
machine that is used for several builds in parallel. Hopefully used cpu
time is a better measure (accuracy is the OS scheduler timeslice).

- CompletionTests2: the monitor cancellation delay of one second is too
unreliable for the build machines we have today, use one minute instead
(the test itself will only wait as much as needed up to the limit, but
not necessarily a minute).


Change-Id: I45957c31957bef3aca425e21f6a44622be18aabd
Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178550
Tested-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests2.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java
Commit 73d5e60e5daf9d82fb72da2650c14359ccf28a28 by Andrey Loskutov
Bug 562324 - reverted workaround not neeeded after compiler fix

Change-Id: Ie98b5f5808650f83187a1961349298a75971dac5
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179500
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/BoundSet.java
Commit 7cd626db39c49a5cbf56a8c5ea532a00fad34054 by Manoj Palat
Bug 572205 - [17][sealed] improved error message for anonymous classes

Change-Id: I93937df77b8dcda877e2e55e898f29f910cde14d
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179490
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Manoj Palat <manpalat@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ClassScope.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/SealedTypesTests.java
Commit 118df565a827a0f766ff1f496b2e88dd8ea6b7d7 by Jay Arthanareeswaran
Bug 572484 - Fix the failing test

Change-Id: Ib962f214ae603002652be8a9f96f71953864b734
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179476
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/TypeBindingTests308.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/AnnotationBinding.java
Commit 316224988fb47eac02c422c8bdd0b85eba90e095 by Jay Arthanareeswaran
Bug 572966 - [test] DOM tests should only be run required levels and
above

Change-Id: Ib09fbf52ff22eea8be11fb24ea6aedd74c0a2fd0
Signed-off-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179534
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingRecordDeclarationTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingInstanceOfPatternExpressionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingSwitchExpressionsTest.java
Commit d01976dba48fa8c3aeb3d7a9670f96a687cd76fb by Andrey Loskutov
Bug 572976 - Disable "new index" tests

Change-Id: Id24c6a21840ceab809ba2e9bf802ee58279c329c
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179516
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/AllJavaModelTests.java
Commit 1e8d2c330d6c9f355e1893333382d51809c457c3 by Andrey Loskutov
Bug 567171 - fix synchronization issue in DeltaProcessingState

Fix problem introduced in Bug 431275. Synchronized on a field always
uses the object. It does not make sense if you assign a new object to
the field.

Change-Id: I7835bc1c92b9962c3aa811d6b6e5db4c578d91d6
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/168851
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Jörg Kubitz <jkubitz-eclipse@gmx.de>
Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessingState.java
Commit e3517ddc41f3c9536a29ef9be4e7dd3104993ab2 by Stephan Herrmann
Bug 539685 - Complete freeze when invoking code assist (infinite loop?)

Reversed strategy for eofPosition during completion parsing.

Change-Id: I8acd53a93ca369b38657b0701ff8e27501f0ffbb
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178809
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/impl/AssistParser.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionOnArgumentName.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/MethodInvocationCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/EnumCompletionParserTest.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionNodeDetector.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/ExplicitConstructorInvocationCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/AnnotationCompletionParserTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests_1_5.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/UnresolvedReferenceNameFinder.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/GenericsCompletionParserTest.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionOnMessageSendName.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ExternalAnnotations18Test.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionParser.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/NameReferenceCompletionTest.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/Parser.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/CompletionParserTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionContextTests.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/CompletionParserTest2.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/ReferenceTypeCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/CompletionRecoveryTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/AbstractCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/CompletionParserTest18.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/FieldAccessCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/InnerTypeCompletionTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/parser/LabelStatementCompletionTest.java
Commit 20132b7f2d17fae55ac849d1953adebbf95d5cd1 by Andrey Loskutov
Bug 572393 - cleaned up warnings in test code

Change-Id: I108bbcf2aac3471041b274af188a3ef2cc076aec
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179581
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests2.java
Commit 9d6248731139a35985aff87bab247f47e9cfcced by Jay Arthanareeswaran
Bug 572977 - Update signing urls and update CBI version to 1.3.1

Change-Id: I242ea461f6206fb043283acf22203f0e451f4fee
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179519
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
The file was modifiedorg.eclipse.jdt.compiler.apt/pom.xml
The file was modifiedorg.eclipse.jdt.compiler.tool/pom.xml
Commit ab2d90d4e73153f0d027bfb01126547b18df36d8 by Stephan Herrmann
Bug 539685 - Complete freeze when invoking code assist (infinite loop?)

- fix for regression in o.e.j.ui.tests.quickfix.AdvancedQuickAssistTest.
testSurroundWithTemplate01

Change-Id: Ie6e154a3e5a31a1b19b751fb4835fbec2440b914
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179673
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
Commit 710763b99d0dee5e9359c15705d59bca21e7e1a8 by Andrey Loskutov
Bug 573084 - ReadManager uses reflection to ask for availableProcessors

Change-Id: I9bda46a6a03687571b06a7fb14c08ec68c9151e5
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179676
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ReadManager.java
Commit 9b8a5c0547986f822224e81d34bd9e666f4aa243 by Stephan Herrmann
Bug 558530 - Calling an enum constructor with a lambda as parameter
crashes the IDE if you forget to seperate the constants with a comma

Change-Id: I31b51bd4dcdaf5414dcc766d490f18c069340e5b
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/178943
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/impl/AssistParser.java
Commit faafc0ab6cd99562ebbe9577db2435ece4750ebd by Stephan Herrmann
Bug 532366 - Autocompletion not available in Enum constructors

Change-Id: Iee81b160c1d671cf8fcb812d9e629d68006b5684
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179390
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionParser.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests_1_5.java
Commit 2cea8caa28fd1fe3e5dcbd43a40f204e1dc84d35 by Andrey Loskutov
Bug 573088 - [test] testLeaksOnCleanBuild fails sporadically on Gerrit

Playing with GC/finalization - may be we have not referenced not closed
stream? If that helps, we probably have a real leak...

Change-Id: I4ad02cf11aad7c5ed6ac2b5d7e59203158957789
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179683
The file was modifiedorg.eclipse.jdt.core.tests.builder/src/org/eclipse/jdt/core/tests/builder/AbstractLeakTest.java
Commit 2523af68f1f5714069768f55260944e646ea1a9e by Stephan Herrmann
Bug 548779 - [1.8][complete] eclipse hangs on String Autocompletion

Change-Id: Ia46a242ac934d30c48781d33f3783c8f71317636
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179694
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit e6acd78ea2da8f35048b3bd85a7c2ce8c808f047 by Stephan Herrmann
Bug 543617 - [completion] Null expectedType when resolving completions
in lambda expressions.

Change-Id: If27575d435391651a0a9480a58b6fbca3e9c4719
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179696
Tested-by: JDT Bot <jdt-bot@eclipse.org>
Reviewed-by: Stephan Herrmann <stephan.herrmann@berlin.de>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
Commit e9a317e2800418a41c182dccb7408f45ac4aaecf by Kalyan Prasad Tatavarthi
Bug 572934 - Records - parameter hiding a field warning

Change-Id: Ic7065c20d54a4196d3936195818c103ecb317868
Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/179660
Tested-by: JDT Bot <jdt-bot@eclipse.org>
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/Argument.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/RecordsRestrictedClassTest.java