FailedChanges

Summary

  1. Bug 567661 - constructor should not leave ZipFile open (details)
  2. Bug 571017 -  Use atomic marker creation API in (details)
  3. Bug 571024 - [performance] Avoid replaceAll(regExp,) (details)
  4. Bug 571055 - [null][batch] EEA for sources also during batch compilation (details)
  5. Bug570593 : Fix completions on nested parameterized type definitions (details)
  6. Bug 571017 - Use atomic marker creation API in AbstractImageBuilder (details)
  7. Bug 560055 - Empty @throws-tag is not visible (details)
  8. Bug 571017 -  Use atomic marker creation API in (details)
  9. Bug 571017 -  Use atomic marker creation API in (details)
  10. Bug 571017 -  Use atomic marker creation API in JavaBuilder (details)
  11. Bug 571159 - cache IPath in ClasspathAccessRule.getPattern() (details)
Commit 77dbd9dac200ce426c5da4aea960129a04353bea by Julian Honnen
Bug 567661 - constructor should not leave ZipFile open

Lazily initialize supportedVersions to
a) avoid leaving a file handle open by simply invoking the constructor.
   Since ClasspathJars are held in the
   JavaModelManager.PerProjectInfo.savedState, that blocks writes to
   those jars even when no build is currently running. This breaks VCS
   updates trying to updated jars in the workspace.
b) reduce the initialization cost. If an instance doesn't ever access
   the supportedVersions, the initialization is unnecessary.

Change-Id: I38a4e7d2bfde5ce49dc7ba520a759b883f5c13c1
Signed-off-by: Julian Honnen <julian.honnen@vector.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ClasspathMultiReleaseJar.java
Commit 231e44f010b13f7919b06c4f9e063abd699c44a2 by Lars Vogel
Bug 571017 -  Use atomic marker creation API in
JavaBuilder#isWorthBuilding

The new marker API from Bug 570914 allows to create markers with
attributes and therefore avoids sending out resource change events for
every attribute change.

Includes an update of the  required resource API version.

Change-Id: I6dfbbfbb3ed1fe6fe499549c5da9a4eb6e36679b
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java
Commit 7744b1ebb9582f7f915951b6ebfc4a79830e785e by Julian Honnen
Bug 571024 - [performance] Avoid replaceAll(regExp,)

Avoiding regular expressions for simple character replacements.
String.replaceAll() is twice as slow as String.replace()
and uses far more ephemeral memory allocation
which result in GC pause times for big projects.
This occurance was not a particular hot spot
but was identified during mass-change.

Bug: 571024
Change-Id: Ifa5aca6581e0e8a075f017dffad7a811a9f17937
Signed-off-by: jkubitz <jkubitz-eclipse@gmx.de>
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/ASTConverter.java
Commit 4c1496dfbd11b3ad81e483bf468882e56f00e870 by Stephan Herrmann
Bug 571055 - [null][batch] EEA for sources also during batch compilation

Change-Id: Ie232aebb4d764746a211d2213976aee954b7ea06
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/NullAnnotationBatchCompilerTest.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/CompilationUnit.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/Main.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/env/ICompilationUnit.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ClassScope.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/SourceFile.java
The file was modifiedorg.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/ClasspathJar.java
Commit d890922f01a874dd5cafce5db8dfb5bae47b2f3c by Vikas Chandra
Bug570593 : Fix completions on nested parameterized type definitions

When invoking on nested parameterized type definitions like
Map<Long, Map<K,V>> completions were not provided to nested
parameterized type indexes other than the last. This issue fix that
problem by properly returning the correct parent node from
CompletionNodeDetector

Change-Id: I6bf59ba4e5d2af82f71486cc6d30ec4880bde080
Signed-off-by: Gayan Perera <gayanper@gmail.com>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests18.java
The file was modifiedorg.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/complete/CompletionNodeDetector.java
Commit 1256b8ec4c0ff791d33f292e6f171848e670db26 by Andrey Loskutov
Bug 571017 - Use atomic marker creation API in AbstractImageBuilder

The new marker API from Bug 570914 allows to create markers with
attributes and therefore avoids sending out resource change events for
every attribute change.

JDT core dependencies have already increased the minimum required
resource API version in a previous commit.

Change-Id: I0d3565990a7f70bcec226d8ee5211c593c3bb30a
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java
Commit 44818033c46c99d90718ff5475803ef85e086173 by Jeff Johnston
Bug 560055 - Empty @throws-tag is not visible

- fix AbstractCommentParser.parseThrows() to reset properly
  after an invalid tag (e.g. missing throws name) to prevent
  an exception later and allowing the empty tag to be added
- add new tests to JavadocTestForMethod and ASTRewritingJavadocTest

Change-Id: I111099c144529e6609a246b72ad89bee67a961d8
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingJavadocTest.java
The file was modifiedorg.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForMethod.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java
Commit 74705dc54fc01a1266ed3025119c915f880a3fd1 by Lars Vogel
Bug 571017 -  Use atomic marker creation API in
AbstractImageBuilder#storeProblemsFor

The new marker API from Bug 570914 allows to create markers with
attributes and therefore avoids sending out resource change events for
every attribute change.

JDT core dependencies have already increased the minimum required
resource API version in a previous commit.

Change-Id: I178b6f36033923329a824f155fe298265aec5962
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java
Commit 54cbcecbcecbf6440267f83b8db07bdcbce457a9 by Lars Vogel
Bug 571017 -  Use atomic marker creation API in
RequestorWrapper

The new marker API from Bug 570914 allows to create markers with
attributes and therefore avoids sending out resource change events for
every attribute change.

Also removes one commented line of code

JDT core dependencies have already increased the minimum required
resource API version in a previous commit.

Change-Id: I8683054f8b77722f40eaba0e61cdc99c3d967171
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/eval/RequestorWrapper.java
Commit 43b405562eab0627b3e3f3bb9aaa3352beb98d40 by Andrey Loskutov
Bug 571017 -  Use atomic marker creation API in JavaBuilder

The new marker API from Bug 570914 allows to create markers with
attributes and therefore avoids sending out resource change events for
every attribute change.

JDT core dependencies have already increased the minimum required
resource API version in a previous commit.

Change-Id: Ie63b8a05d2cf7ef6b4bfe20900b7d9dc66e853bd
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/JavaBuilder.java
Commit db0505ae83209e88f185623ebb5db1d077ff30f3 by Andrey Loskutov
Bug 571159 - cache IPath in ClasspathAccessRule.getPattern()

Creating IPath can cost ~ 1% of build time

Change-Id: I773d8fc70096e5ec8debb2da1870455ee4fb5d55
Signed-off-by: jkubitz <jkubitz-eclipse@gmx.de>
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ClasspathAccessRule.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/env/AccessRule.java