FailedChanges

Summary

  1. Bug 547181 - [9][impl] Reconsider representation and lookup of packages (details)
  2. Revert "Bug 548956 - Rewrite should work based on previewEnabled flag of (details)
  3. Bug 547181 - [9][impl] Reconsider representation and lookup of packages (details)
  4. Bug 547181 - [9][impl] Reconsider representation and lookup of packages (details)
  5. Bug 548956 - Rewrite should work based on previewEnabled flag of AST (details)
Commit 7404b0f200034ff780553aca9ce3c785a56994aa by register.eclipse
Bug 547181 - [9][impl] Reconsider representation and lookup of packages
(SplitPackageBinding)
- replace remaining PlainPackageBinding constructor invocations
- putting packages into ModuleBinding.declaredPackages in
ModuleBinding.addPackage is then not needed, after removing it,
remaining functionality can be inlined
- removed some unnessary code in MB.getVisiblePackage from the time when
declaredPackages could contain SplitPackageBindings
- always put into cache in MB.getVisiblePackage and remove cache
handling from getTopLevelPackage
Change-Id: Ibd7bddebff4e0315f0f08a5486acd714bc3c46f8
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ModuleBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/PlainPackageBinding.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/LookupEnvironment.java
Commit e4fe6ea66ca018ddb36a728587b87392d8f5c0b8 by sarika.sinha
Revert "Bug 548956 - Rewrite should work based on previewEnabled flag of
AST"
This reverts commit 357185ef691b346646bc98aa38ba4950222dbc6a.
Change-Id: Ie6b6e839193fe304df6af0b3360a1f8fdf18e647
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/NaiveASTFlattener.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingStatementsTest.java
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/rewrite/ASTRewriteAnalyzer.java
The file was modifiedorg.eclipse.jdt.core/dom/org/eclipse/jdt/internal/core/dom/rewrite/ASTRewriteFlattener.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingSwitchExpressionsTest.java
Commit 32a3857797bf19248aee13ba9b4a02f63d66f233 by register.eclipse
Bug 547181 - [9][impl] Reconsider representation and lookup of packages
(SplitPackageBinding)
- IResource.getFileExtension() can return null
- add null checks in LE.combine: for ProblemReferenceBindings, fPackage
can be null
- output directory can contain subdirectories with copied resources, so
fall back to sources if no .class found
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/LookupEnvironment.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ClasspathDirectory.java
The file was modifiedorg.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/ClasspathMultiDirectory.java
Commit 3122a06e3a023df004c6d9fca731a8e0da4ab108 by register.eclipse
Bug 547181 - [9][impl] Reconsider representation and lookup of packages
(SplitPackageBinding)
- add test for fixed NPE problem because of IResource.getFileExtension()
- avoid duplicate declared packages
Change-Id: Ib41b0575734541805a8750dcc542397bfc3c52f2
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/ModuleBuilderTests.java
The file was modifiedorg.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/LookupEnvironment.java
Commit 98197a6e247571eb5aaa4483ec70e8deece6d6e8 by sarika.sinha
Bug 548956 - Rewrite should work based on previewEnabled flag of AST
Change-Id: If1e02d077f2af60de859a68d0c02e25766bc93e8 Signed-off-by:
Sarika Sinha <sarika.sinha@in.ibm.com>
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingSwitchExpressionsTest.java
The file was modifiedorg.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/rewrite/describing/ASTRewritingStatementsTest.java