SuccessChanges

Summary

  1. Initial scaffolding to more extensively test string serialization of user defined CellTypes. (details)
  2. Refactoring of code responsible for translating to/from CellType definitions (details)
  3. Moved widening bit math into companion of WideIntNoData. (details)
  4. Added additional tests around behavior of WidenedNoData class. (details)
  5. Fixed additional bug in writing out the no-data value in TIFF files. (details)
  6. Added additional CellType encoding test to to through writing/reading actual TIFF file. (details)
Commit 5176d1343be6ec0aa45d7e76954917281236745d by Simeon H.K. fitch
Initial scaffolding to more extensively test string serialization of user defined CellTypes.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster/src/main/scala/geotrellis/raster/io/json/Implicits.scala (diff)
The file was modifiedraster-test/src/test/scala/geotrellis/raster/CellTypeSpec.scala (diff)
Commit 64a76a9b9d654256b5e4e7dc114299b9eaa97b63 by Simeon H.K. fitch
Refactoring of code responsible for translating to/from CellType definitions
and string representations, particularly for JSON serialization. Addresses issues
outlined in #2166, where specific NoData values that are negative, or ones
for unsigned CellTypes that overflow JVM native encodings (e.g. uint8ud255).
As a part of the refactoring, expanded the tests around edge cases associated
with numeric bounds. The only public API change is the addition of the
method `UserDefinedNoData.widenedNoData`.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster-test/src/test/scala/geotrellis/raster/CellTypeSpec.scala (diff)
The file was modifiedraster/src/main/scala/geotrellis/raster/UserDefinedNoDataConversions.scala (diff)
The file was addedraster/src/main/scala/geotrellis/raster/CellTypeEncoding.scala
The file was modifiedraster/src/main/scala/geotrellis/raster/CellType.scala (diff)
Commit c7bdf738d098d41162bc41281af065d1c7bf79a8 by Simeon H.K. fitch
Moved widening bit math into companion of WideIntNoData.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster/src/main/scala/geotrellis/raster/CellType.scala (diff)
The file was modifiedraster/src/main/scala/geotrellis/raster/CellTypeEncoding.scala (diff)
Commit 5501fda2b39a66670a0ef1a75d1cf5d7c7771f8f by Simeon H.K. fitch
Added additional tests around behavior of WidenedNoData class.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster-test/src/test/scala/geotrellis/raster/CellTypeSpec.scala (diff)
Commit 658f956fa6e5022f84b7a424628736dd3bbfafd8 by Simeon H.K. fitch
Fixed additional bug in writing out the no-data value in TIFF files.
Found by @mteldridge

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster-test/src/test/scala/geotrellis/raster/CellTypeSpec.scala (diff)
The file was modifiedraster/src/main/scala/geotrellis/raster/CellTypeEncoding.scala (diff)
The file was modifiedraster/src/main/scala/geotrellis/raster/io/geotiff/writer/TiffTagFieldValue.scala (diff)
Commit 8e999c32daf96d9b53dd4fa11af3dd6d17bdfd12 by Simeon H.K. fitch
Added additional CellType encoding test to to through writing/reading actual TIFF file.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
The file was modifiedraster-test/src/test/scala/geotrellis/raster/CellTypeSpec.scala (diff)
The file was modifiedraster/src/main/scala/geotrellis/raster/io/geotiff/writer/TiffTagFieldValue.scala (diff)