SuccessChanges

Summary

  1. Rename variables Fortify think are hardcoded encryption keys (details)
  2. Avoid exposing confidential information in a repo URI (details)
  3. Move HTTP remotes password encryption where its used (details)
  4. Fix fortify privacy violation concern on RepositoryResolver (details)
  5. Remove unused imports (details)
  6. Clean up code: remove blocks of commented out code (details)
  7. Fortify: do not log geopkg sql statements (details)
  8. Move experimental modules to a new experimental/ parent (details)
  9. Move command hook scripting to experimental module (details)
  10. Fix Clone functional test assert (details)
Commit c4938caff3bd28144d365a77589af4997187d917 by groldan
Rename variables Fortify think are hardcoded encryption keys
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/porcelain/RevertOp.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/porcelain/SquashOp.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/porcelain/CommitOp.java (diff)
Commit 84a1d66b417a6e7b6d835c984edb49c398691c19 by groldan
Avoid exposing confidential information in a repo URI
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/api/src/main/java/org/locationtech/geogig/repository/RepositoryResolver.java (diff)
Commit aa3a721e8bdd7782d8981f95e65e3f6d23a5f5c1 by groldan
Move HTTP remotes password encryption where its used
Remote is a value object and should have no logic. Move password
encryption/decryption to HttpRemoveResolver where is belongs
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/api/src/test/java/org/locationtech/geogig/repository/RemoteTest.java (diff)
The file was modifiedsrc/web/api/src/test/java/org/locationtech/geogig/web/api/commands/RemoteManagementTest.java (diff)
The file was modifiedsrc/api/src/main/java/org/locationtech/geogig/repository/Remote.java (diff)
The file was modifiedsrc/web/api/src/main/java/org/locationtech/geogig/remote/http/HttpRemoteResolver.java (diff)
The file was addedsrc/web/api/src/main/java/org/locationtech/geogig/remote/http/HttpRemotePasswordHook.java
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/plumbing/remotes/RemoteAddOp.java (diff)
The file was addedsrc/web/api/src/main/resources/META-INF/services/org.locationtech.geogig.hooks.CommandHook
Commit 32aa8d5e170372a8740a333fcd52f66af07f8e28 by groldan
Fix fortify privacy violation concern on RepositoryResolver
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/api/src/main/java/org/locationtech/geogig/repository/RepositoryResolver.java (diff)
The file was modifiedsrc/storage/postgres/src/main/java/org/locationtech/geogig/storage/postgresql/PGRepositoryResolver.java (diff)
The file was modifiedsrc/storage/postgres/src/main/java/org/locationtech/geogig/storage/postgresql/config/ConnectionConfig.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/repository/impl/FileRepositoryResolver.java (diff)
The file was modifiedsrc/storage/postgres/src/main/java/org/locationtech/geogig/storage/postgresql/config/EnvironmentBuilder.java (diff)
Commit e785271493f24f8bdb1b1407ff932ab1708b7461 by groldan
Remove unused imports
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/datastore/src/main/java/org/locationtech/geogig/geotools/data/reader/ScreenMapGeometryReplacer.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/plumbing/remotes/RemoteRemoveOp.java (diff)
The file was modifiedsrc/datastore/src/main/java/org/locationtech/geogig/geotools/data/reader/SimplifyingGeometryReplacer.java (diff)
The file was modifiedsrc/datastore/src/test/java/org/locationtech/geogig/geotools/data/GeoGigDiffFeatureSourceTest.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/plumbing/DiffFeature.java (diff)
The file was modifiedsrc/api/src/main/java/org/locationtech/geogig/model/RevObjects.java (diff)
The file was modifiedsrc/storage/cache/caffeine/src/test/java/org/locationtech/geogig/cache/performance/ObjectCacheStressTest.java (diff)
The file was modifiedsrc/api/src/test/java/org/locationtech/geogig/model/HashObjectFunnelsTest.java (diff)
Commit 022a2a680178176c0b90db7fd00afd8df733a25a by groldan
Clean up code: remove blocks of commented out code
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/cli/core/src/main/java/org/locationtech/geogig/cli/GeogigCLI.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/model/internal/ClusteringStrategy.java (diff)
The file was modifiedsrc/api/src/main/java/org/locationtech/geogig/repository/Remote.java (diff)
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/plumbing/DiffFeature.java (diff)
Commit c60713220dfd56bddf098b3f17f0cff1494992b9 by groldan
Fortify: do not log geopkg sql statements
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/geotools/src/main/java/org/locationtech/geogig/geotools/geopkg/GeopkgGeogigMetadata.java (diff)
Commit e1104bcb4c9b18a47128c29915ec14ee7786c324 by groldan
Move experimental modules to a new experimental/ parent
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was addedsrc/experimental/gui/pom.xml
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/SetUseProvidedFidSimpleFeatureCollection.java
The file was removedsrc/gui/src/main/java/org/locationtech/geogig/gui/cli/Map.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/cli/QLModule.java
The file was addedsrc/experimental/gui/src/main/resources/META-INF/services/org.locationtech.geogig.cli.CLIModule
The file was addedsrc/experimental/gui/src/main/java/org/locationtech/geogig/gui/cli/Map.java
The file was removedsrc/gui/src/test/java/org/locationtech/geogig/gui/internal/MapPaneTest.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLDelete.java
The file was addedsrc/experimental/gui/src/test/java/org/locationtech/geogig/gui/internal/MapPaneTest.java
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/cli/QLSelectIntegrationTest.java
The file was addedsrc/experimental/gui/src/main/java/org/locationtech/geogig/gui/internal/MapPane.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/cli/QLUpdatetIntegrationTest.java
The file was removedsrc/gui/src/main/java/org/locationtech/geogig/gui/internal/MapPane.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/ExpressionLiteralExtractor.java
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/cli/QLInsertIntegrationTest.java
The file was removedsrc/gui/pom.xml
The file was addedsrc/experimental/pom.xml
The file was addedsrc/experimental/gui/src/main/java/org/locationtech/geogig/gui/cli/GuiCommandsModule.java
The file was removedsrc/gui/src/main/resources/META-INF/services/org.locationtech.geogig.cli.CLIModule
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/cli/QLModule.java
The file was addedsrc/experimental/ql/pom.xml
The file was modifiedsrc/pom.xml (diff)
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/cli/QLUpdatetIntegrationTest.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLSelect.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/cli/QLInsertIntegrationTest.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLUpdate.java
The file was removedsrc/ql/src/main/resources/META-INF/services/org.locationtech.geogig.cli.CLIModule
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLInsert.java
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/porcelain/ExpressionToFilterConverterTest.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/StatementVisitorAdapter.java
The file was addedsrc/experimental/ql/README.md
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/StatementVisitorAdapter.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/cli/QLSelectIntegrationTest.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/porcelain/ExpressionToFilterConverterTest.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLDelete.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLUpdate.java
The file was removedsrc/gui/src/main/java/org/locationtech/geogig/gui/cli/GuiCommandsModule.java
The file was addedsrc/experimental/ql/src/main/resources/META-INF/services/org.locationtech.geogig.cli.CLIModule
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/cli/QL.java
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLSelect.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/cli/QLDeleteIntegrationTest.java
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/cli/QLDeleteIntegrationTest.java
The file was addedsrc/experimental/ql/src/test/java/org/locationtech/geogig/ql/cli/QLTestHelper.java
The file was removedsrc/ql/README.md
The file was removedsrc/ql/src/main/java/org/locationtech/geogig/ql/porcelain/ExpressionToFilterConverter.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/ExpressionToFilterConverter.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/ExpressionLiteralExtractor.java
The file was removedsrc/ql/pom.xml
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/QLInsert.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/porcelain/SetUseProvidedFidSimpleFeatureCollection.java
The file was removedsrc/ql/src/test/java/org/locationtech/geogig/ql/cli/QLTestHelper.java
The file was addedsrc/experimental/ql/src/main/java/org/locationtech/geogig/ql/cli/QL.java
Commit a913fbbecbdff51b1357459d18ba739696875273 by groldan
Move command hook scripting to experimental module
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/Scripting.java
The file was removedsrc/core/src/test/java/org/locationtech/geogig/test/integration/HooksTest.java
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/hooks/CommandHookChain.java (diff)
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/GeoGigAPI.java
The file was addedsrc/experimental/scripting/src/test/java/org/locationtech/geogig/scripting/HooksTest.java
The file was modifiedsrc/experimental/pom.xml (diff)
The file was addedsrc/experimental/scripting/README.md
The file was removedsrc/core/src/main/java/org/locationtech/geogig/hooks/ShellScriptHook.java
The file was removedsrc/core/src/test/resources/META-INF/services/org.locationtech.geogig.hooks.CommandHook
The file was removedsrc/core/src/main/java/org/locationtech/geogig/hooks/Hookables.java
The file was removedsrc/core/src/main/resources/org/locationtech/geogig/hooks/pre_commit.js.sample
The file was removedsrc/core/src/main/java/org/locationtech/geogig/hooks/GeoGigAPI.java
The file was modifiedsrc/cli/app/pom.xml (diff)
The file was removedsrc/core/src/main/java/org/locationtech/geogig/hooks/JVMScriptHook.java
The file was addedsrc/experimental/scripting/src/test/java/org/locationtech/geogig/scripting/GeogigAPITest.java
The file was removedsrc/cli/core/src/test/java/org/locationtech/geogig/cli/test/functional/RunHooksFunctionalTest.java
The file was removedsrc/core/src/main/resources/META-INF/services/org.locationtech.geogig.repository.RepositoryResolver
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/JVMScriptHook.java
The file was addedsrc/experimental/scripting/src/main/resources/org/locationtech/geogig/scripting/pre_commit.js.sample
The file was removedsrc/core/src/test/java/org/locationtech/geogig/test/integration/GeogigAPITest.java
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/hooks/CommandHook.java (diff)
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/ShellScriptHook.java
The file was addedsrc/experimental/scripting/src/test/resources/features/hooks/Hooks.feature
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/hooks/CommandHooksDecorator.java (diff)
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/ScriptHookWrapper.java
The file was addedsrc/experimental/scripting/pom.xml
The file was removedsrc/core/src/main/java/org/locationtech/geogig/hooks/Scripting.java
The file was addedsrc/experimental/scripting/src/test/resources/META-INF/services/org.locationtech.geogig.hooks.CommandHook
The file was modifiedsrc/core/src/main/java/org/locationtech/geogig/repository/impl/FileRepositoryResolver.java (diff)
The file was addedsrc/experimental/scripting/src/test/java/org/locationtech/geogig/scripting/functional/RunHooksFunctionalTest.java
The file was addedsrc/experimental/scripting/src/main/java/org/locationtech/geogig/scripting/InitializeHooksHook.java
The file was addedsrc/experimental/scripting/src/main/resources/META-INF/services/org.locationtech.geogig.hooks.CommandHook
The file was removedsrc/cli/core/src/test/resources/features/hooks/Hooks.feature
Commit a7eb401a89b4d634ed6325ccb0afafc5825757f7 by groldan
Fix Clone functional test assert
Fix expected substring after changed introduced by commit 32aa8d.
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/cli/remoting/src/test/resources/features/remote/Clone.feature (diff)