SuccessChanges

Summary

  1. Simplify PGConfigDatabase.resolveRepositoryPK() (details)
  2. Avoid failure to return the pg config db if the repository does not (details)
  3. Avoid stack trace when trying to unalias a CLI command (details)
  4. Make CLI get the ansi.enabled config from file based global config only (details)
Commit ea8391db2b02ff468c6b9fb926c3018173899020 by groldan
Simplify PGConfigDatabase.resolveRepositoryPK()
Look at the geogig_repository_name view instead, which is far easier.
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/storage/postgres/src/main/java/org/locationtech/geogig/storage/postgresql/PGConfigDatabase.java (diff)
The file was modifiedsrc/cli-app/src/main/java/org/locationtech/geogig/cli/app/CLI.java (diff)
Commit e75187459b7f8c63a267450c8e61f1f2b578851e by groldan
Avoid failure to return the pg config db if the repository does not
exist.
PGRepositoryDatabase.getConfigDatabase(...) assumed the repository
pointed out by the URI exists if the repository name is present in the
URI, in order to set the storage.refs, storage.objects, etc config
properties default values (which is odd by the way, and will be not
necessary when we simplify the plugins mechanism).
Yet, the repository may not exist and the config db still may be needed
to set/get global options. This caused an exception, now prevented by
checking if the repo exists before trying to set the storage config
settings.
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/storage/postgres/src/main/java/org/locationtech/geogig/storage/postgresql/PGRepositoryResolver.java (diff)
Commit 213cd199363c15c112cb1dea25f891685ede77c9 by groldan
Avoid stack trace when trying to unalias a CLI command
Trying to run a CLI command on a repo that doesn't exist resulted in a
stack trace instead of the proper resolving of the aliased command
Now it checks if the repo exists before trying to get the local config,
and falls back to the /home/groldan/.geogigconfig file based global
config if needed, as most of the time that's where one configure aliases
even if working with postgres backed repos
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/cli/src/main/java/org/locationtech/geogig/cli/GeogigCLI.java (diff)
Commit 1a7c9f48f526a1d1fd92f24a6b5d232a9493f437 by groldan
Make CLI get the ansi.enabled config from file based global config only
The ansi.enabled config option only makes sense on a per
terminal/OS/machine basis and hence we shall only use it through the
$HOME/.geogigconfig global config. This also avoids errors trying to get
the config value from the PG repository resolver which is not friendly
with the rootUri boolean argument of its getConfigDatabase mehtod.
Signed-off-by: Gabriel Roldan <groldan@boundlessgeo.com>
The file was modifiedsrc/cli-app/src/main/java/org/locationtech/geogig/cli/app/CLI.java (diff)
The file was modifieddoc/manual/source/repo/config.rst (diff)