SuccessChanges

Summary

  1. [443954] Fix listener were not properly unregistered within VCL. (details)
  2. [443954] Invert y-axis of Dot by default (so we obtain proper coords). (details)
  3. [443954] Fix routers do not properly respect coordinate systems. (details)
  4. [443954] Ensure connection refreshes on hint changes. (details)
  5. [443954] Ensure interpolator uses updated start and end points. (details)
  6. [443954] Ensure listener registration is appropriate within Connection. (details)
  7. [443954] Add proper translation to AnchorageReferencePoint. (details)
  8. [443954] Refactor GeometryNode to be specific Region instead of Parent. (details)
  9. [443954] Enhance ConnectionSnippet to use orthogonal router. (details)
  10. [NONE] Update image sources for GEF4 Common. (details)
Commit 86566d64dae6c33c439abc90d80ed17dfd7f8b56 by anyssen
[443954] Fix listener were not properly unregistered within VCL.

- Fixed visual change listener did not remove all listeners within
unregister().
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/listeners/VisualChangeListener.java (diff)
Commit 0e3929f1efe59773e1b91203d4e888bcbc5ad53b by anyssen
[443954] Invert y-axis of Dot by default (so we obtain proper coords).
The file was modifiedorg.eclipse.gef4.dot.ui/src/org/eclipse/gef4/dot/internal/ui/DotGraphView.java (diff)
The file was modifiedorg.eclipse.gef4.dot.tests/src/org/eclipse/gef4/dot/tests/DotExecutableUtilsTests.java (diff)
The file was modifiedorg.eclipse.gef4.dot.ui/src/org/eclipse/gef4/dot/internal/ui/Dot2ZestAttributesConverter.java (diff)
The file was modifiedorg.eclipse.gef4.dot/src/org/eclipse/gef4/dot/internal/DotExecutableUtils.java (diff)
Commit 7c7241fe08ba37d56ee3d5b4263cb630ba9d3187 by anyssen
[443954] Fix routers do not properly respect coordinate systems.

- Fixed StraightRouter and OrthogonalRouter did not properly compute AnchoredReferencePoint
within the coordinate system of the anchored, which is the Connection's
curve node.
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/OrthogonalRouter.java (diff)
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/StraightRouter.java (diff)
Commit 0d3db9157396b77200c40e603ec09d0b0cbf8d6a by anyssen
[443954] Ensure connection refreshes on hint changes.
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/Connection.java (diff)
Commit 5e5c74e11f23c7b573f05d94509fee68ae697734 by anyssen
[443954] Ensure interpolator uses updated start and end points.

- Ensured interpolator does not skip in case of empty geometry and
updates decorations based on computed geometry.
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/AbstractInterpolator.java (diff)
Commit d3b6e45a8454a2459f1b7e6a528287b363eab757 by anyssen
[443954] Ensure listener registration is appropriate within Connection.

- Fixed transform listener was not properly registered on new curve
node.
- Added a layout bounds listener to the curve node (to trigger a refresh
on the connection).
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/Connection.java (diff)
Commit 9965cf0af5604f0a11aaa43c3b53daf9fcabc67f by anyssen
[443954] Add proper translation to AnchorageReferencePoint.

- Ensure AnchorageReferencePoint is specified within coordinate system
of anchored.
The file was modifiedorg.eclipse.gef4.mvc.tests.fx/src/org/eclipse/gef4/mvc/tests/fx/FXBendConnectionPolicyTests.java (diff)
Commit a5e8687fce7a529b4a8f714082bac752f4af99cc by anyssen
[443954] Refactor GeometryNode to be specific Region instead of Parent.

- Refactor GeometryNode to extend Region, rather than Parent, so the deprecated impl_calculateLayoutBounds() no longer has to be overwritten. The contract is now that the geometry reflects the geometric size and position (in parent coordinates). That is, the GeometryNode is relocated and resized when the geometry is changed. Clients can now use relocate and resize to manipulate the visual bounds as well as relocateGeometry/resizeGeometry to manipulate the geometric bounds. The GeometryNode will listen to stroke type and width changes and will update the visual bounds.
- Added tests to guarantee proper behavior.
- Made NodeUtils robust against GeometryNodes with no geometry.
- Ensured that feedback geometry is properly translated to parent coordinates within FXSelectionFeedbackPart, FXHoverFeedbackPart, and FXFocusFeedbackPart.
The file was modifiedorg.eclipse.gef4.fx.examples/src/org/eclipse/gef4/fx/examples/ConnectionSnippet.java (diff)
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/utils/NodeUtils.java (diff)
The file was modifiedorg.eclipse.gef4.mvc.fx/src/org/eclipse/gef4/mvc/fx/parts/FXSelectionFeedbackPart.java (diff)
The file was modifiedorg.eclipse.gef4.fx.tests/src/org/eclipse/gef4/fx/tests/AllTests.java (diff)
The file was modifiedorg.eclipse.gef4.fx/src/org/eclipse/gef4/fx/nodes/GeometryNode.java (diff)
The file was modifiedorg.eclipse.gef4.zest.fx/src/org/eclipse/gef4/zest/fx/parts/NodePart.java (diff)
The file was modifiedorg.eclipse.gef4.mvc.fx/src/org/eclipse/gef4/mvc/fx/parts/FXFocusFeedbackPart.java (diff)
The file was addedorg.eclipse.gef4.fx.tests/src/org/eclipse/gef4/fx/tests/GeometryNodeTests.java
The file was modifiedorg.eclipse.gef4.mvc.fx/src/org/eclipse/gef4/mvc/fx/parts/FXHoverFeedbackPart.java (diff)
Commit 7857e49a00c166a3bf3de32236cd29a9cdf8161b by anyssen
[443954] Enhance ConnectionSnippet to use orthogonal router.

- Ensured that one edge uses orthogonal routing for demonstration
purposes.
The file was modifiedorg.eclipse.gef4.fx.examples/src/org/eclipse/gef4/fx/examples/ConnectionSnippet.java (diff)
Commit c53ae9da480d7d44fb4a2b598647bdae1b4bc7cf by anyssen
[NONE] Update image sources for GEF4 Common.
The file was modifiedorg.eclipse.gef4.common.doc/image_src/org.eclipse.gef4.common.eap (diff)
The file was addedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-collections-fxreplacements.png
The file was modifiedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-beans-binding-fxreplacements.png (diff)
The file was modifiedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-beans-property-fxreplacements.png (diff)
The file was modifiedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-beans-property-guava.png (diff)
The file was addedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-collections-guava-listeners.png
The file was modifiedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-beans-binding-guava.png (diff)
The file was addedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-collections-guava.png
The file was modifiedorg.eclipse.gef4.common.doc/image_src/GEF4-Common-beans-value.png (diff)