Skip to content

Changes

Summary

  1. [gpg] Improve error handling in signature verification (details)
  2. [gpg] Use the Bouncy Castle light-weight API directly (details)
Commit 3e03eda59f023543406f92cfad38a1dc406e7c3d by Thomas Wolf
[gpg] Improve error handling in signature verification

Besides logging errors also add a line in the CommitInfoBuilder telling
the user that something went wrong, and to look in the error log for
details.

Change-Id: I07c6b2aac819d1d4f821e80d1cac864c0aadf219
Signed-off-by: Thomas Wolf <twolf@apache.org>
The file was modified org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/UIText.java
The file was modified org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties
The file was modified org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitInfoBuilder.java
Commit 8dc5abdc16661e9f0249a3563ff6d0d610564dda by Thomas Wolf
[gpg] Use the Bouncy Castle light-weight API directly

No need to go through JCA for just parsing a signature. We can use BC
as a simple library, which makes the code work even if the Bouncy Castle
security provider is not installed.

Change-Id: Ie5609aedfa36aeb3560504cb69a7e89f6583c52d
Signed-off-by: Thomas Wolf <twolf@apache.org>
The file was modified org.eclipse.egit.core/src/org/eclipse/egit/core/internal/signing/ExternalGpgSigner.java
The file was modified org.eclipse.egit.core/META-INF/MANIFEST.MF