SuccessChanges

Summary

  1. Revert "Tuleap #655 - Only let user try to delete a reviewer if (details)
  2. Address instability in the execution of FileRenameAcrossRevision (details)
  3. Tuleap #679 - Compare editor does not show difference across a rename (details)
  4. Bug 507710 - Hover on stars is not very useful (details)
  5. Tuleap #681 - Update reviews open in editors (details)
  6. Tuleap #717 -  Adjust the column size for the files in compare editor (details)
Commit a43d93508c6ecf9c8040ecdc8abbda8f0fa4d226 by Jacques Bouthillier
Revert "Tuleap #655 - Only let user try to delete a reviewer if allowed".

Doing further testing on this revealed that the removed button does not show at all. Reverting this to where we were because at least users will be able to delete reviewers, whereas with this patch applied, they can't.

This reverts commit c446993eb6302e57ac49840ed9962b889039e3d7 from review 85170.

Change-Id: Ic368af83dd52131aa2c4ff74f42abba46cdb03c7
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/DetailsTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/provider/ReviewersTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/UIUtils.java
Commit 9f8ff9e530fd06aa292dd0072067eb8cd5ae284c by Pascal Rapicault
Address instability in the execution of FileRenameAcrossRevision

Sort the list of files in the compare editor

Change-Id: I1bc3be1e41e369b88db52a3b975b00a8ae27bc55
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/FileRenamedAcrossRevision.test
Commit 9fd66c20d45a5ffe44057d03f362af6458f10bad by Pascal Rapicault
Tuleap #679 - Compare editor does not show difference across a rename

The constants used to identify the changes were causing the compare
framework to detect our change like a 3 way compare
(ContentMergeViewer#internalRefresh) which is incorrect.

Change-Id: If1d133663023a61fc6d95794d19b212d9047733f
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritDifferences.java
Commit 8d8b606517d94ad814b477e32128f788820c5ac8 by Pascal Rapicault
Bug 507710 - Hover on stars is not very useful

Update the message to be a bit more useful

Change-Id: Ieab54d1b031cb2a0a848449158a753c8f8c5b5ec
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/messages.properties
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/Messages.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/ReviewTableLabelProvider.java
Commit 1a4282d179a9eb77821cf5bc3c217ab3a92ab989 by Jacques Bouthillier
Tuleap #681 - Update reviews open in editors

Change-Id: I0b67872e96102684b73774f1c78cd3298a0a4199
Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com>
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/RebaseProcess.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/RefreshRelatedEditors.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/SubmitProcess.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
Commit 0bc72de16b0513f73ed56560e2117daa649828c8 by Pascal Rapicault
Tuleap #717 -  Adjust the column size for the files in compare editor
and in History tab view

Change-Id: Ibec2f77a4b1606d2bce6e4a9c624df62be94e06d
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/model/FilesTableModel.java