SuccessChanges

Summary

  1. Tuleap #687 - Add tooltip to subject widget (details)
  2. Externalize strings and add $NON-NLS-*$ where needed. (details)
  3. Tuleap #701 - Improve navigation in FilesDialog (details)
  4. Refresh button should force a refresh of everything (details)
  5. Tuleap #516 - Don't suggest other exact patchsets when user attempts to (details)
  6. Tuleap #703 - QuickDiff not properly enabled (details)
  7. Tuleap #670 - Comments not properly colored in Gerrit 2.13 (details)
  8. Tuleap #655 - Only let user try to delete a reviewer if allowed (details)
Commit a5c013293ce446fd560b32c9e3fe817d17bb9b6d by Pascal Rapicault
Tuleap #687 - Add tooltip to subject widget

Change-Id: I01a75625673515c012bac5deb379d86f7450a43b
Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ChangeDetailEditor.java
Commit 7401dc839375ca8ec3e2b6aab9c7bb9aa71f79e5 by Patrick-Jeffrey Pollo Guilbert
Externalize strings and add $NON-NLS-*$ where needed.

Change-Id: I92842dec4c9f6c723ec29647d7c20160655db4f1
Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/CheckoutRevisionTest.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/CommentExtractorTest.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/EGerritConstants.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/utils/Messages.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/EditionLimiterTests.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareUpperSection.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/internal/rcptt/support/ReviewFactory.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/model/ReviewersTableModel.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/command/EMFTypeAdapterFactory.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/QueryHelpers.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/ChangeIdExtractor.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/ChangeIdExtractorTest.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/InsertionTest.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/GerritRepository.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/model/HistoryTableModel.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/EnterHttpInSearchTest.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/messages.properties
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/CommandTest.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/UIReviewTable.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/HyperLinkDetectorTest.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/QueryChangesCommandTest.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/EGerritCorePlugin.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/provider/FileInfoCompareCellLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowCommentedFileAction.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/DashboardCompletionTest.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/CheckoutRevision.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/InputData.java
The file was modifiedorg.eclipse.egerrit.dashboard.core/src/org/eclipse/egerrit/internal/dashboard/utils/GerritServerUtility.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/VoteHandler.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/model/FilesTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
Commit a5e24c53094eadd47d9409a0cdfcf74a5e9b5fe2 by Pascal Rapicault
Tuleap #701 - Improve navigation in FilesDialog

- Persist value store for the column sorting
- Add CTRL+Shift+5 to navigate backward when the FilesDialog is open
- Allow to navigate the table with the arrow up/down to select the
next/previous elemnet
- Using SHIFT+ arrow up/down will select multiple elements in the table

Change-Id: I1676f3d45757b4b0db9aadc635a84f05acb3beeb
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/OpenFileSelectionHandler.java
The file was modifiedorg.eclipse.egerrit.ui/plugin.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/model/ReviewTableSorter.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/FilesDialog.java
The file was modifiedorg.eclipse.egerrit.ui/plugin.xml
Commit 0484ed76beba47b087ac9bae986bda4d598f5db2 by Pascal Rapicault
Refresh button should force a refresh of everything

Introduce a parameter to force a full reload of a review in query helpers
and propagate it all the way to the ModelHelper layer.

Change-Id: Icebfcd1b06ec11245562cd980e0882d94a02af27
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/RebaseProcess.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/SubmitProcess.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/DetailsTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ModelLoader.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/provider/DeleteDraftRevisionProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/ReplyProcess.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/MessageTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/QueryHelpers.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/CherryPickProcess.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/process/OpenCompareProcess.java
Commit 3fcfe707c226b021d195a8266c76e98234b89795 by Jacques Bouthillier
Tuleap #516 - Don't suggest other exact patchsets when user attempts to
checkout patchset

Change-Id: I3ed5030711fe0bacb6d0a74681e1c2b0f56d323f
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/CheckoutRevision.java
Commit f5a77b729236751ce3e5f31d067315b482a52d29 by Pascal Rapicault
Tuleap #703 - QuickDiff not properly enabled

The quick-diff can sometimes be on, but even in this case
we need to force all the preferences.

Change-Id: I534035ec3c6782789f9c13f560a329fb1ba0ecf4
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/ActiveWorkspaceRevision.java
Commit 2c67c1a20fa8ff537c148761a092da47e2701d0b by Jacques Bouthillier
Tuleap #670 - Comments not properly colored in Gerrit 2.13

The CommentAnnotationPainter needs to store the chosen color using the
author account id instead of the username because it can be null.

Change-Id: I3f1ff19c464e6c722281ed690e7ad2eb64bd215e
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentAnnotationPainter.java
Commit c446993eb6302e57ac49840ed9962b889039e3d7 by Pascal Rapicault
Tuleap #655 - Only let user try to delete a reviewer if allowed

Change-Id: I65c263ecbda665bdf8769cac8f3182f880889b38
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/provider/ReviewersTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/DetailsTabView.java