SuccessChanges

Summary

  1. -Adjust the history tab view to balance the table VS message data (details)
  2. make slf4j dependency optional (details)
  3. Revert "make slf4j dependency optional" (details)
  4. UI: make SameTopicTableLabelProvider EMPTY_STRING static (details)
  5. UI: comment out code in switch case (details)
  6. UI: Introduce BaseTableLabelProvider (details)
  7. - NPE on the EGerrit server definition (details)
  8. - Refresh the Change Detail Editor after the Submit (details)
  9. List Branches and Branch Info implementation (details)
Commit 63761cd5e7c6fe9895ffbf3d00bc4d69634c01bd by Jacques Bouthillier
-Adjust the history tab view to balance the table VS message data

Change-Id: I6acbfa68d0a79cd45ab10096fa36b023c7b4857c
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/HistoryTabView.java
Commit 1222cdb197b33b641b90ac2613ae417d5813de22 by gperron
make slf4j dependency optional

Change-Id: I5aca56add22e98f1bf87048c633c06545ad2a05e
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.core/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
Commit 30e6e4497e6fc693e920acb72164e80dd4855aa8 by Guy Perron
Revert "make slf4j dependency optional"

This reverts commit 1222cdb197b33b641b90ac2613ae417d5813de22.

Change-Id: I13aef679c674cde906d51d873de6ef2237514b86
The file was modifiedorg.eclipse.egerrit.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.dashboard.core/META-INF/MANIFEST.MF
Commit b2f741905ec5f583502b86e8e354a7528998e19f by Jacques Bouthillier
UI: make SameTopicTableLabelProvider EMPTY_STRING static

Change-Id: Iaa318632747a602fe27e5f0ffdc308028f360255
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/SameTopicTableLabelProvider.java
Commit d084cd7c8fdb7faf58aa4b55c676649a9d3e55ac by Jacques Bouthillier
UI: comment out code in switch case

The value of "value" will always be null, so the code was dead.

Change-Id: I266ed66a70f39a0496412a7a5b875d225f5ef2c0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/SameTopicTableLabelProvider.java
Commit 24e70ccdc0dcc7eab9c172f92b4fddac741b04f1 by Jacques Bouthillier
UI: Introduce BaseTableLabelProvider

In order to minimize clutter in the code base, common functionalities
have been extracted to the BaseTableLabelProvider.

This class provides:
* empty strings
* default colors
* getBackground (color)
* getForeground (color)
* formatValue - explicitly sign numbers

A class extending this should override the getColumnText method.

Change-Id: I9270bb7a0a01fc362e48670f5731775626023851
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/BaseTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/ReviewersTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/SameTopicTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/ConflictWithTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FilePatchSetTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/RelatedChangesTableLabelProvider.java
Commit ed657a3f83c541d7d7f3cfd623db246d95e92ac7 by Jacques Bouthillier
- NPE on the EGerrit server definition
- Add tooltip to show the user what to enter in the server dialog

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=477495

Change-Id: I5676b00db3bb39a6c132b6fe147abd1aaa038896
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritServerDialog.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritRepository.java
Commit 3ab18e92a79711a59dd21a1995b0c489a0ad93fa by Jacques Bouthillier
- Refresh the Change Detail Editor after the Submit

Change-Id: Ia1d3025846dd9530182d0cf7b945e38b42260f99
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
Commit 4d75364f488bbab13564e96e4495bc35048971cc by Guy Perron
List Branches and Branch Info implementation

Change-Id: Id824836452c979ab1381043e343fa8ecf52d8b11
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was addedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/rest/BranchInfo.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritClient.java
The file was addedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/ListBranchesCommandTest.java
The file was addedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/command/ListBranchesCommand.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/AllEGerritCoreTests.java
The file was addedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/rest/tests/BranchInfoTest.java