SuccessChanges

Summary

  1. Fix preference page layout and enablement (details)
  2. Filtering comments does not work multiple times in a row (details)
  3. Test the next/previous comment buttons (details)
  4. remove deadcode (details)
  5. Get the compare editor by its name rather than position (details)
  6. Add test case for star feature (details)
  7. Remove unnecessarily created patchsets from the tests (details)
  8. add tests for listprojects and suggestaccount commands (details)
  9. Test shortcut to switch to the next patchset (details)
  10. Remove deadcode from GerritTableView (details)
  11. Test the next/previous file button (details)
  12. Test anonymous user can't run certain queries (details)
  13. Add marker activation test case. (details)
  14. Add test for topics (details)
  15. Add test for query completion (details)
  16. Fix the port problem (details)
  17. Adjust the proxy for the test. (details)
  18. Clean up some warnings (details)
  19. Add finer grain exception handling in test to understand what is failing (details)
  20. Close the httpclient after each test (details)
  21. Print full exception on sys.out to help debug failing tests (details)
  22. Remove deadcode (details)
  23. Add more tests on dashboard completion (details)
  24. clean dead code (details)
  25. Test modification and deletion of drafts (details)
  26. Test the change file presentation action (details)
  27. Test the open review editor from compare (details)
  28. Add test for the checkout option. (details)
Commit dd7f5d67c2e7b832d3ea4a54ea9924d2fb4b382f by Michael Keppler
Fix preference page layout and enablement

The button for server creation, modification and deletion now use the
same size. They automatically become enabled or disabled depending on
the selection of the table.

Change-Id: Ia4961e5be7dfaf0f0d347bc8c3a07a64c86239d3
Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/preferences/GerritDashboardPreferencePage.java
Commit 382c5c24e26d5f920306f3f45b2355ace7ef67ac by Pascal Rapicault
Filtering comments does not work multiple times in a row

We are going back to an IAction instead of a CommandHandler because it
is simpler to deal with the state of the button.

Change-Id: Ideff64f686cc5dd58dcd00479de35f88b0bc231c
The file was modifiedorg.eclipse.egerrit.ui/plugin.xml
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowCommentedFileHandler.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/FilterCommentedFiles.test
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowCommentedFileAction.java
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareUpperSection.java
Commit 1528b04afb7d8bea10738a91e109855d6f42fbec by Pascal Rapicault
Test the next/previous comment buttons

Also add a new helper to get the right end side of the compare editor
and use it where necessary

Change-Id: I24b458665c93083d3a17dd98f671942eea0afc09
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/NextPreviousCommentAction.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorComment.test
Commit 23b7d632ef53735993e9f2560a9535733fdec8d9 by gperron
remove deadcode

Change-Id: Iaf2f01c7d67274919f8fbcc72b94b43a7e5d0222
The file was removedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/command/PublishDraftRevisionCommand.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/GerritClient.java
The file was removedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/PublishDraftRevisionCommandTest.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ChangedFileFilter.java
The file was removedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/command/GetReviewedFiles.java
Commit acab96208f97684e53ee08626070f9d70e70d146 by Pascal Rapicault
Get the compare editor by its name rather than position

Change-Id: Id8a0c4116a8c66406ddc2f97cbca13b17c135546
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorDefaultOpen.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorChangeInput.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CommentInReplyDialog.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorComment.test
Commit 6623e3f026db5a4ddbc54a01889d7095c285fa22 by Guy Perron
Add test case for star feature

Change-Id: Idd1f3e859ddb4b92b676b558ca72a281fa65f11a
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/dashboard/ValidateStar.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
Commit 2dfa8a07a992bcf0b9a3c6b0d8e8d9168c266e9d by Pascal Rapicault
Remove unnecessarily created patchsets from the tests

Change-Id: I3ba712df766790ae4ab81260e4be87ccf2410fde
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/reviewEditor/SubmitRevertReview.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorComment.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CommentInReplyDialog.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/NextPreviousCommentAction.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/FilterCommentedFiles.test
Commit ce757e3e02a668556af8145b2516ccc2a0e39915 by gperron
add tests for listprojects and suggestaccount commands

Change-Id: I5d360ab50a2e022d87bc5a9e511ac8e273c0ce6f
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was addedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/SuggestAccountCommandTest.java
The file was addedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/ListProjectsCommandTest.java
Commit d3f312dc46f134ae08cb08d0cf2941e6cc0552f4 by Pascal Rapicault
Test shortcut to switch to the next patchset

Change-Id: Icb4762ae48e8eae7b7f2b1f346e1807b83140317
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/compare/CompareEditorChangeInput.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
Commit 5a9798f207770c7f1bc1520e540ea61c5f1bed29 by Pascal Rapicault
Remove deadcode from GerritTableView

Change-Id: Iff05c799d18a013f0154cbaa971108f8a326c05f
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/GerritTableView.java
Commit 314013747a63ec57abeca787a5919b724696f025 by Pascal Rapicault
Test the next/previous file button

Change-Id: I363b462e5cd033c17b9b67c6fca7eb870d1d5355
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/GoToNextFile.test
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/internal/rcptt/support/ReviewFactory.java
Commit 54abf59f81aa24749f37ef6d069aac1b9252a943 by Pascal Rapicault
Test anonymous user can't run certain queries

Change-Id: I782380472851a6d7b25e15b7c101bda9a0574678
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/dashboard/TestInvalidQueriesForAnonymous.test
Commit c4ac3bca8b040627e6172330d76496dd1db0b5f0 by gperron
Add marker activation test case.

Change-Id: I8bde2be008c1b16a1ebfda25d88ca26d47523681
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/reviewEditor/ActivateMarkerView.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx.orig
Commit 1935e71fd464a2a64fe59a71cbece53943d6b5f8 by Pascal Rapicault
Add test for topics

Change-Id: I2b12202711de6f91b59f7be29801bb0a23e2a33d
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/reviewEditor/AddTopic.test
Commit bfcf8bfa6753ed96a69e4b6fdf16f5f5d15921f1 by Pascal Rapicault
Add test for query completion

Change-Id: I56f85f71b7f6df5cde2f71edbf914aba193ba51e
The file was addedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/DashboardCompletionTest.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
Commit b71371ab92037e703eb31cd3138b8e33631ca25c by gperron
Fix the port problem

Change-Id: Ie9fc2fe14675f4ff84adfd6c96712844ecce24d2
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/DashboardCompletionTest.java
Commit 64406a548f16e1df1960255d9d28d82fd4725724 by Jacques Bouthillier
Adjust the proxy for the test.

Change-Id: Iac91104be0fc553d6842b9d2cf48c3c49a0e23da
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/DashboardCompletionTest.java
Commit fb7fdd44ecbb941245841d7b604f10dcf98ea43e by Jacques Bouthillier
Clean up some warnings

Change-Id: Ide24422227d11018aeca3809e090a49c1f96e7ed
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/GerritRepository.java
Commit db78c25446040a0430345bd9d89b1c7f16d2582d by Pascal Rapicault
Add finer grain exception handling in test to understand what is failing

Change-Id: Iec9d61fb82022c8abde189f708eca1e5bab08525
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/CommandTest.java
Commit 714b7ca33ddfca5bf4299864973e4d9a9c84f8df by Pascal Rapicault
Close the httpclient after each test

Change-Id: I13c933e0813e3dcfb55bb272b0c6f134b033b6b9
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/CommandTest.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/GerritHttpClient.java
Commit 0ddb4b7cf2af795ec2e52f9a1bf432602ec78d78 by Pascal Rapicault
Print full exception on sys.out to help debug failing tests

Change-Id: I45be76389321d6eb7c90e221d78e0c372a16374f
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/CommandTest.java
Commit 75a7fcecf4c3c0a1c791376be3058bf73d1c63af by Pascal Rapicault
Remove deadcode

Change-Id: I3b4a060fcc3006c98ffe2f4224dab6625fbf0365
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/UICompareUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/AnnotationContributionItems.java
Commit 369ee61882f457d2f9ad7444e1153e1f9c5ece7f by Pascal Rapicault
Add more tests on dashboard completion

Change-Id: I33e503579004b21d332dff9134818980dbedbdad
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/DashboardCompletionTest.java
Commit c3654e613a025181d8afa269320950e8d0b603b6 by Pascal Rapicault
clean dead code

Change-Id: Ibeb71308ad418263b8ab246afb629dfd71054355
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritDiffNode.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/UIFilesTable.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/DataConverter.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/TextViewerWithLinks.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/provider/BaseTableLabelProvider.java
Commit f9746d6e062ce9b3d967757ed536e7f9ffab7c16 by Pascal Rapicault
Test modification and deletion of drafts

Change-Id: Idcb807a0f7d07b17d0f8f5be8e3c47761fbbf300
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/ModifyDeleteDraft.test
Commit d5dac936b3ea756eade4459ec187a11ab96283ca by Pascal Rapicault
Test the change file presentation action

Change-Id: I9ad09b4bd88dcb8729ee3a1226251d9d785044fd
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/ChangeFilenamePresentation.test
Commit 5607eeda8e91b46a2b272792500b6187c10a2cfe by Pascal Rapicault
Test the open review editor from compare

Change-Id: I7348691914164f18ed6ddfabce83dfcf5898aefe
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/compare/OpenReviewEditor.test
Commit beb7abf6b3c056d7fa9227efbf3b694c73f10f0a by Jacques Bouthillier
Add test for the checkout option.

Change-Id: I7949e5335e351344a41036e5dd7eb2b3dbb3cadd
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/CheckoutRevision.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/PublishDraftChangeCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/support/GitAccess.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/AbandonCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/QueryChangesCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.core/.settings/org.eclipse.jdt.core.prefs
The file was modifiedorg.eclipse.egerrit.ui.tests/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/GetChangeCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/RestoreCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/GetCommitMsgCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/SetTopicCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/CommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/RevertCommandTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/SubmitCommandTest.java
The file was addedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/CheckoutRevisionTest.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/DeleteDraftChangeCommandTest.java