SuccessChanges

Summary

  1. Tuleap #370 Display message dialog when the user enables the markers (details)
  2. tuleap #515 Don't propose to checkout a commit that is on top of a (details)
  3. [Compare] Next/previous comment button missing in the compare editor (details)
  4. Point to release repo of Eclipse Neon (details)
  5. Tuleap 476 - Provide completion when cherry-picking to a branch (details)
  6. Revive and improve rcptt tests (details)
  7. setup proxy preferences for testing (details)
  8. Exclude generated code from Sonar analysis (details)
  9. Second attempt at removing generated code from sonar (details)
  10. Improve tip message for markers and cleanup message keys. (details)
  11. Model plugin should not ship its source code in the binary (details)
  12. Add about.html (details)
  13. Tuleap 299 - Add content assist to dashboard search (details)
  14. tuleap 527 Fix concerns in the code from next/previous group of comment (details)
  15. Put in place foundation for automated tests with RCPTT (details)
  16. Increase test readability by introducing procedures for assertions (details)
  17. Tuleap #535 Cannot open related change when changeId is not unique (details)
  18. Test built-in queries (details)
  19. Update doc of the CreateReview command (details)
  20. Use Java 1.8 for UI test (details)
  21. Test dashboard buttons (details)
Commit da1d6637a8b849d00a327842c28e2e066fc5fa90 by Jacques Bouthillier
Tuleap #370 Display message dialog when the user enables the markers

Change-Id: I248b867a3d90eed23f99fa160395a8bef67122d5
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/UIFilesTable.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
Commit 8fb71ab1a81b3e0d5b92da6cf25bcdda1d0fcd6f by Jacques Bouthillier
tuleap #515 Don't propose to checkout a commit that is on top of a different branch than the review

Change-Id: I5f6f06239f6393fe8f115a20750cf00ed3cde80b
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/CheckoutRevision.java
Commit 8e269a0f43d481855671e1c7301548fe93ca08c6 by Jacques Bouthillier
[Compare] Next/previous comment button missing in the compare editor
Loop to the next/previous comment within the same file

Change-Id: Ieff3fa40c7f39386d298a7b759a394353a6ff247
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/plugin.xml
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/PreviousCommentAnnotationHandler.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/AnnotationContributionItems.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/NextCommentAnnotationHandler.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritCommentAnnotation.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/EditionLimiterTests.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
The file was addedorg.eclipse.egerrit.ui/icons/nxtcomment_menu.png
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritMultipleInput.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/UICompareUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentableCompareItem.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/EditionLimiter.java
The file was addedorg.eclipse.egerrit.ui/icons/prevcomment_menu.png
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/CommentExtractorTest.java
Commit 28226219f56bfa85df6b9773ca835e459767dab5 by Pascal Rapicault
Point to release repo of Eclipse Neon

Change-Id: I77aa6441a781bd7825e49c1ade321dc66d571f8f
The file was modifiedorg.eclipse.egerrit.target/eGerrit-Eclipse_4.6-neon.target
Commit 6de2b4e3901f3adaa6581db910bf52dc817013c8 by Marc Khouzam -- away until July 25th 2016
Tuleap 476 - Provide completion when cherry-picking to a branch

Change-Id: I964e927cfc7edda802bda3414534f9f464faedca
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/CherryPickDialog.java
Commit b949d585b1fb63db05ba396143e5d032be584b60 by gperron
Revive and improve rcptt tests

Change-Id: I52872413f62ea8d2b3f36576b7845f7857c479ef
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/pom.xml
Commit efcc84491d9b272f9b30c47feb07bd529290fe20 by gperron
setup proxy preferences for testing

Change-Id: I82ad749ea425ae3fa289eb6c7315a4afae843a03
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/001Test.test
Commit 2e0daa299523c62cec2e22ea15321a95b48c2b6f by Pascal Rapicault
Exclude generated code from Sonar analysis

Change-Id: I30d573980fef0b0abce46f1c0e0c1018ba65d985
The file was modifiedpom.xml
Commit 6bb988b1b7790430dbba8cdad8aafacc77b22682 by Pascal Rapicault
Second attempt at removing generated code from sonar

Change-Id: I2c41f1b333a89a7c3e80899ef760c7324f25e5c7
The file was modifiedpom.xml
Commit 0df24006c8ca0e8f1d93630340773f52f97e1841 by Pascal Rapicault
Improve tip message for markers and cleanup message keys.

Change-Id: Ie30bb0d1106ad5a086e2298dbd8c315cbbbcbd3b
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/table/UIFilesTable.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
Commit 87a553e81603b24b425819ef0d46af12c1dff421 by Pascal Rapicault
Model plugin should not ship its source code in the binary

Change-Id: Id557ee2b6a4d5d23b2172e696799e3d9ad17f43c
The file was modifiedorg.eclipse.egerrit.model/build.properties
Commit 7a5df966acaf74a83de93b2e8c33a82362526e34 by Pascal Rapicault
Add about.html

Change-Id: Ie029524ad70ddcf7169d55d6ba481aac3451a323
The file was addedorg.eclipse.egerrit.model.edit/about.html
The file was addedorg.eclipse.egerrit.model/about.html
The file was modifiedorg.eclipse.egerrit.model.edit/build.properties
The file was modifiedorg.eclipse.egerrit.model/build.properties
Commit ba73e561f82db4c5c1fedf9854c341c126c36468 by Marc Khouzam
Tuleap 299 - Add content assist to dashboard search

Provides content-assist for the dashboard search just like webGerrit.

Current limitations:

3- Missing completion for accountGroups.
I don't understand how gerrit uses accountGroups, so I wasn't planning
on adding support for it.  I personally don't think it is a blocker.

4- The completion matches what is supported by the gerrit server 2.11.2.
There are new completions possibly available in newer versions.
Not sure what to do about this one.

Change-Id: Ia013fae797583427395fba50ddcb1e1a6acd59d6
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/GerritClient.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/SearchContentProposalProvider.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/ProjectNameCompleter.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/SearchContentProposalAdapter.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/SearchContentProposal.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/AccountGroupCompleter.java
The file was addedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/command/SuggestAccountCommand.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/AccountCompleter.java
The file was addedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/internal/core/command/ListProjectsCommand.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/completion/ParamCompleter.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/views/GerritTableView.java
Commit 698db18db956482d27b2b81bc8746f0aab6ad081 by Jacques Bouthillier
tuleap 527 Fix concerns in the code from next/previous group of comment


Change-Id: Iec1667e65edb3cc71d0c8cf6b6725122101e9a7b
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/EditionLimiterTests.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritCommentAnnotation.java
The file was modifiedorg.eclipse.egerrit.ui/plugin.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/messages.properties
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/NextPreviousCommentAnnotationHandler.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/NextCommentAnnotationHandler.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/EditionLimiter.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/PreviousCommentAnnotationHandler.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentableCompareItem.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/CommentExtractorTest.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/AnnotationContributionItems.java
The file was modifiedorg.eclipse.egerrit.ui/plugin.xml
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/UICompareUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/EGerritImages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/utils/Messages.java
Commit ead9b9c33eb9660694fac8c6357f4e469038689a by Pascal Rapicault
Put in place foundation for automated tests with RCPTT

Change-Id: I3ece712cbc51bfa0d3450d88f7f93c09e6b9d996
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/pom.xml
The file was removedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/SetupRCPTTHandler.java
The file was modifiedorg.eclipse.egerrit.ui.tests/META-INF/MANIFEST.MF
The file was addedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/internal/rcptt/support/CreateReviewService.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/ConfigureDefaultServer.ctx
The file was modifiedorg.eclipse.egerrit.ui.tests/plugin.xml
The file was modifiedorg.eclipse.egerrit.ui.tests/.classpath
The file was addedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/internal/rcptt/support/ReviewFactory.java
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A4Restore.test
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/impl/CreateReviewImpl.java
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A1SetupVagrantServer.test
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/CreateReview.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInDetailsTab.test
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/impl/egerriteclFactoryImpl.java
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/egerriteclFactory.java
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/egerriteclPackage.java
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A2SelectReview.test
The file was modifiedorg.eclipse.egerrit.ui.tests/pom.xml
The file was modifiedorg.eclipse.egerrit.ui.tests/plugin.properties
The file was modifiedorg.eclipse.egerrit.target/eGerrit-Eclipse_4.6-neon.target
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/rcptt.properties
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/support/GitAccess.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/ChangeCommitMessage.test
The file was modified.gitignore
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A0setupRCPTT.test
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/util/egerriteclAdapterFactory.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/CheckButtons.test
The file was addedorg.eclipse.egerrit.ui.tests/model/egerritecl.ecore
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/CleanupWorkbench.ctx
The file was addedorg.eclipse.egerrit.ui.tests/model/egerritecl.genmodel
The file was removedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/GerritClientAuthenticationTest.java
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/SetGlobalVariables.ctx
The file was modifiedorg.eclipse.egerrit.ui.tests/build.properties
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/SanityCheck.suite
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/SetProxyToDirect.ctx
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A7Revert.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A9FileTabDisplayOrder.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/B0DraftReviews.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A5OverView.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A8RefreshDashboard.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/001Test.test
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A3Abandon.test
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/AbandonRestore.test
The file was removedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/RCPTTInitialSetOfReviews.java
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/A6OpenCompareEditor.test
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInMessageTab.test
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/impl/egerriteclPackageImpl.java
The file was addedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/util/egerriteclSwitch.java
The file was removedorg.eclipse.egerrit.ui.rcptt.tests/B1SelectReviewerFromList.test
Commit d5735f3ab841af481007002931c47a5099af7cb1 by Pascal Rapicault
Increase test readability by introducing procedures for assertions

Change-Id: If45a0e42404fb80e4cd8904b063df8ff5a98f4b4
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInDetailsTab.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/AbandonRestore.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/CheckButtons.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/ChangeCommitMessage.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInMessageTab.test
Commit 58be57a490b86f55cc3a65a3aa911dabbe5ec233 by Jacques Bouthillier
Tuleap #535 Cannot open related change when changeId is not unique
Using the changeInfo Id sems more appropriate to query the server
and get the right review. It seems we could get an error when using
the changeId only.

Change-Id: I38089a859795d29ea2b6ce28c4d04f6fa82ed220
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/tabs/DetailsTabView.java
Commit 5932c627627914a954ce889f03ba65e858bf6310 by Jacques Bouthillier
Test built-in queries

Change-Id: Iedf81ae2596fcfff829782c5fdc0f65854e52ff3
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInDetailsTab.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/CheckLinksInMessageTab.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/HelperScripts.ctx
Commit 4ac7d2ffbeaad44c656d795da0106c7994ac077f by Jacques Bouthillier
Update doc of the CreateReview command

Change-Id: Ibc43de83c15ddb04cf32fe170baaa762af26059d
The file was modifiedorg.eclipse.egerrit.ui.tests/model/egerritecl.ecore
The file was modifiedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/CreateReview.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/egerriteclPackage.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src-gen/org/eclipse/egerrit/internal/rcptt/support/egerritecl/impl/egerriteclPackageImpl.java
Commit 4246b7ae61cdd22c02f5bca92833583d221ce500 by Jacques Bouthillier
Use Java 1.8 for UI test

Change-Id: Id26dab631fa00f6dd9fa718fe028fd5c36f3b441
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui.tests/.settings/org.eclipse.jdt.core.prefs
The file was modifiedorg.eclipse.egerrit.ui.tests/.classpath
The file was modifiedorg.eclipse.egerrit.ui.tests/META-INF/MANIFEST.MF
Commit c3054e3354f6b7ed14a1b890876778a991b64918 by Pascal Rapicault
Test dashboard buttons

Change-Id: I228324bedaaa4515b732055ed8540caa7bb5c834
The file was addedorg.eclipse.egerrit.ui.rcptt.tests/ValidateBuiltInQueries.test