SuccessChanges

Summary

  1. Add constant (details)
  2. Remove irrelevant comments (details)
  3. Bug 491719 - Optimize dashboard columns to show as much as webGerrit (details)
  4. Externalize strings (details)
  5. Cleanup images and images invocations (details)
  6. Bug 491640 - [Details tab] Details tab does not open to actual size and (details)
  7. exec unit test with Gerrit 2.11 (details)
  8. Revert "Bug 491640 - [Details tab] Details tab does not open to actual (details)
  9. Bug 491640 - [Details tab] Details tab does not open to actual size and (details)
  10. Revert "Bug 491640 - [Details tab] Details tab does not open to actual (details)
  11. Bug 494091 - Performance issue with sorting logic (details)
  12. Make label provider for files consistent (details)
  13. Bug 478967 - Review column resizability and default sizes (details)
  14. Remove unused externalized string. (details)
  15. Externalize dashboard's strings (details)
  16. Cleanups (details)
  17. Remove return value from SetTopic command (details)
  18. NPE when setting reviewed flag (details)
Commit 9579414421d344863e6fba202933751948bb006d by Pascal Rapicault
Add constant

Change-Id: I680b0634558ebc8d3c8c80eeb2b4f213f761a798
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareItemFactory.java
Commit 0ace28f14c5209b45d0c83eb0411cf5a12ff7c82 by Pascal Rapicault
Remove irrelevant comments

Change-Id: I56093fcde1fc9568ac9c5e719282be626993624a
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/EGerritUIPlugin.java
Commit 1408da4f89d68af1666abc5f57e98036368e8363 by Jacques Bouthillier
Bug 491719 - Optimize dashboard columns to show as much as webGerrit
when full screen

Change-Id: I8fba4a0f840d53e8269c3715a147c5b62d365bd9
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/.classpath
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.target/eGerrit-Eclipse_4.6-neon.target
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/UIReviewTable.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
Commit a0ea3d95aa72fcca101e24d8c45c61de0d231045 by Jacques Bouthillier
Externalize strings

Change-Id: I62f3d0c30442650754ce36bacdc5ae6ed10c9a85
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareUpperSection.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/ActiveWorkspaceRevision.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/messages.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/MarkerMenuContribution.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixer.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/CherryPickDialog.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/HyperLinkPresenter.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/EditionLimiter.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/CheckoutRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/ConflictWithTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyToComment.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyDoneToComment.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/FilesTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/DataConverter.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/ReviewersTableModel.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/messages.properties
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/SubmitType.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/messages.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/DeleteDraftRevisionProvider.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/SwitchPatchAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/RelatedChangesTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/EGerritHyperlinkManager.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ReplyAction.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/HistoryTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/CherryPickRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/NextPreviousFileAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowFilePathAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixModifyDraft.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/MessageTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/UIUtils.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ReplyDialog.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/HistoryTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixDeleteDraftComment.java
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/Messages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritMultipleInput.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/SameTopicTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileInfoCompareCellLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/messages.properties
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowCommentedFileAction.java
Commit 639d264597033ecee8a53a3ec64a329d76ae057b by Jacques Bouthillier
Cleanup images and images invocations

Change-Id: Id4be8a0ba71d1285d9ecd2dbdb99a2f987b1955b
The file was removedorg.eclipse.egerrit.ui/icons/ovr16/reply.png
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ReplyAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/EGerritImages.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyDoneToComment.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowCommentedFileAction.java
The file was addedorg.eclipse.egerrit.ui/icons/delete.gif
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/HistoryTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/NextPreviousFileAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileInfoCompareCellLabelProvider.java
The file was removedorg.eclipse.egerrit.ui/icons/ovr16/delete.gif
The file was removedorg.eclipse.egerrit.ui/icons/ovr16/edit.gif
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/SwitchCurrentPathsetAction.java
The file was addedorg.eclipse.egerrit.ui/icons/edit.gif
The file was removedorg.eclipse.egerrit.ui/icons/ovr16/done.png
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowFilePathAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/SwitchPatchAction.java
The file was removedorg.eclipse.egerrit.ui/icons/arrowDown.png
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyToComment.java
Commit c37b9aa7f239be81588a2301e223e2acb056e1ae by Pascal Rapicault
Bug 491640 - [Details tab] Details tab does not open to actual size and
needs to be re-sized

Change-Id: Ic64b6dc2c17b0601ffc57e20f28425e001ec107f
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit d0e5979254f2c95068524629797f952f1c1e6555 by Jacques Bouthillier
exec unit test with Gerrit 2.11
Remove temporary the rcptt test

Change-Id: Icb6f57ad0a3fe8673dddd4c8f27ace426dd3635b
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/Common.java
The file was modifiedpom.xml
Commit 98650c082884af51efa57d67f4fad55fe724c9ec by Guy Perron
Revert "Bug 491640 - [Details tab] Details tab does not open to actual size and needs to be re-sized"

This reverts commit c37b9aa7f239be81588a2301e223e2acb056e1ae.

Change-Id: I9cda64a0520da6a5d1ed08c2587b67445644f16d
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit fff924aedf7e11e30197378b966d94573cca6935 by gperron
Bug 491640 - [Details tab] Details tab does not open to actual size and
needs to be re-sized

Change-Id: I067accdc25a9673ac027507ce02be9a59f8f5c62
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit 42f96fe7dfabec26e3136952cf86cfcc480773eb by Guy Perron
Revert "Bug 491640 - [Details tab] Details tab does not open to actual size and needs to be re-sized"

This reverts commit fff924aedf7e11e30197378b966d94573cca6935.

Change-Id: Ia16b883b21cac1a4e7149a20f4b775bef677562a
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit a81aefee6a2083d7c960cdef17bbe6ff2ef5e6c6 by Pascal Rapicault
Bug 494091 - Performance issue with sorting logic

Change-Id: I64c7f70f4c3d91bc1328a3c392f7612d6e0bf8c3
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/ReviewTableSorter.java
Commit b1904cb03f7e9e77eb7f9b2b771cb184356065ac by Pascal Rapicault
Make label provider for files consistent

The logic of the label provider in FileTableLabelProvider needs to be
the same than in FileInfoCompareCellLabelProvider

Change-Id: Id61b1f8830f7620d52bf71a7d569f1c6f3a343d1
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/FileInfoCompareCellLabelProvider.java
Commit 76c5bc4e9d26e29369ad95c5d04adb35928d48aa by Jacques Bouthillier
Bug 478967 - Review column resizability and default sizes


Change-Id: Ib54e7965da4a41527d31b23b02058d6007c47d8e
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.core/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/ReviewersTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/HistoryTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/META-INF/MANIFEST.MF
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/DetailsTabView.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/HistoryTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentPrettyPrinter.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/utils/Utils.java
Commit 52ac57971648bd4861f386d3f5cc80a1ffb46c06 by Marc Khouzam
Remove unused externalized string.

I got a warning when launching EGerrit saying:

Warning: NLS missing message: SummaryTabView_26 in:
org.eclipse.egerrit.ui.internal.utils.messages

When I checked about SummaryTabView_26, I noticed it was never used.

Change-Id: I085aec2d3c55942e88380f649a51ac8021bbef57
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/Messages.java
Commit 5baf2fa147a82ed6ffd6d4216aaad5bd84dffe91 by Pascal Rapicault
Externalize dashboard's strings

Change-Id: I99b368312d4b2b2130a90734e51b826bbf0da0d5
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritDashboardPreferencePage.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritServerDialog.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/Messages.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritServerTableLabelProvider.java
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/messages.properties
Commit f5a069de380d3e530ffba3b2e3fb450765aab9f1 by Pascal Rapicault
Cleanups

Change-Id: Id406d8244e5c23853a2a967aab16ccdebe358d25
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/Utils.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/commands/my/MyWatchedChangesReviewsHandler.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/UIReviewTable.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/commands/table/AdjustMyStarredHandler.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/utils/Utils.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableSorter.java
Commit 1c1295ac71137e2392e71ee21d4e4fb14a5a56f1 by Pascal Rapicault
Remove return value from SetTopic command

Change-Id: I0297430a51b1704101bc531de20d4e26bd0795f8
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/command/SetTopicCommand.java
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/command/tests/SetTopicCommandTest.java
Commit 7ad3391b1af117b79431b43522a760cd2b56f7ab by Pascal Rapicault
NPE when setting reviewed flag

Change-Id: I8d5f96f1a163718537c87138281523de37786b11
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QueryHelpers.java