SuccessChanges

Summary

  1. Adjust the rcptt test with the reply dialog (details)
  2. Bug 487929 - [dashboard] Provide hover for truncated string (details)
  3. Regenerate code (no model change) (details)
  4. Add SourceReferences to plugins (details)
  5. Bug 491642 - [Details tab] Strategy string messed up (details)
  6. Bug 492547 - Refresh the content of the dashboard when the reviews are (details)
  7. Bug 493264 - [Compare] Save with workspace on right leads to wrong (details)
  8. Bug 490287 - [Usability] Dashboard layout is not persisted across (details)
  9. Bug 493431 - NPE when performing a request on starred as anonymous (details)
  10. Bug 491277 - Reply fails on Gerrit 2.12 (details)
  11. Cleanup the code that get the auth key (details)
  12. Bug 480254 - Button to cherry-pick change onto local branch. (details)
  13. Bug 492850 - In Gerrit server dialog, Enter should do OK (details)
Commit 68580f4aad6856b1a0f3c62a18c7467f9d470de8 by Jacques Bouthillier
Adjust the rcptt test with the reply dialog

Change-Id: Ifbc0074757c24d8c3a671c31d9f3fec3eeff24df
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/001Test.test
Commit d533509e098e3bd3902967297047ace9442dbea3 by gperron
Bug 487929 - [dashboard] Provide hover for truncated string

Change-Id: Icca1ab7514a8faaf09c71f24810a7730c5fe2416
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/UIReviewTable.java
Commit bfc3a96238ccbbf719abc416f510ee9191ae15c9 by Pascal Rapicault
Regenerate code (no model change)

Change-Id: I7702c609699477121404ab0f58c08c644bbe8f1a
The file was modifiedorg.eclipse.egerrit.model.edit/plugin.properties
The file was modifiedorg.eclipse.egerrit.model.edit/src-gen/org/eclipse/egerrit/internal/model/provider/RevisionInfoItemProvider.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/FileInfoTest.java
The file was modifiedorg.eclipse.egerrit.model.edit/src-gen/org/eclipse/egerrit/internal/model/provider/ChangeMessageInfoItemProvider.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/EgerritAllTests.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/RevisionInfoTest.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/StringToListOfStringTest.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/ChangeInfoTest.java
The file was modifiedorg.eclipse.egerrit.model.edit/src-gen/org/eclipse/egerrit/internal/model/provider/ChangeInfoItemProvider.java
The file was modifiedorg.eclipse.egerrit.model.tests/src-gen/org/eclipse/egerrit/internal/model/tests/ModelTests.java
Commit f2f192e0a818543c82cb8d9fea0f758ec43d68fc by Pascal Rapicault
Add SourceReferences to plugins

This allows the user to clone and checkout the source code of EGerrit
without knowing where the repository is. See:
https://wiki.eclipse.org/PDE/UI/SourceReferences

One use case is to right-click on a plug-in under the Plug-in
dependencies in Package Explorer view and select Import from Repository.
Note that for this EGit needs to be installed.

Another use case is to go to
File > Import > Plug-In Development > Plug-ins and Fragments then select
Projects from a repository.

What this patch does is to let Tycho generate the source references in
the MANIFEST.MF of the built jars. So to test this patch, one can build
the update site locally and inspect the manifests of the (non-source)
jars.

Also see:
http://download.eclipse.org/releases/staging/buildInfo/reporeports/reports/esdata.txt

Change-Id: I50aa1ff1e18bf77c62f80a7d823ee4b060a9198b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The file was modifiedpom.xml
Commit 7db3909ac24294000f994c85631c531f159bb501 by gperron
Bug 491642 - [Details tab] Strategy string messed up

Change-Id: Ib2e9ecb6d7b375db6d3bae3c06cebb908f83392e
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit 198e0a5715204da9e03e71843b348ee93b851492 by Pascal Rapicault
Bug 492547 - Refresh the content of the dashboard when the reviews are
changing

Use EMF generated code to remove any forced refresh

Change-Id: I264c13e4eadd8fc1f50324e31a77cead72306980
The file was modifiedorg.eclipse.egerrit.dashboard.ui/.settings/org.eclipse.jdt.core.prefs
The file was modifiedorg.eclipse.egerrit.model/model/egerrit.genmodel
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableLabelProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/MessageTabView.java
The file was modifiedorg.eclipse.egerrit.model.edit/src-gen/org/eclipse/egerrit/internal/model/provider/ChangeInfoItemProvider.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
The file was addedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ModifiedModelItemProviderAdapterFactory.java
The file was modifiedorg.eclipse.egerrit.model/.settings/org.eclipse.jdt.core.prefs
The file was removedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableContentProvider.java
The file was removedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/ReviewTableData.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/internal/model/UIReviewTable.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/views/GerritTableView.java
The file was modifiedorg.eclipse.egerrit.model/src-gen/org/eclipse/egerrit/internal/model/impl/RevisionInfoImpl.java
The file was modifiedorg.eclipse.egerrit.model.edit/src-gen/org/eclipse/egerrit/internal/model/provider/ReviewsItemProvider.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/DeleteDraftRevisionProvider.java
Commit d862b10fc93c39e595c89daa3302c3ea28eeb1f7 by Jacques Bouthillier
Bug 493264 - [Compare] Save with workspace on right leads to wrong
version being displayed

Change-Id: Id80c50095c198337bd3e68c053c897828b760ba8
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritCompareHelper.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritMultipleInput.java
Commit 98608ababe9d57ecc65ee37fec48a54d0037c4e3 by gperron
Bug 490287 - [Usability] Dashboard layout is not persisted across
restarts


Change-Id: I86364609ece152b5dd0dc2004b8d42b1bdc4b2ba
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/views/GerritTableView.java
Commit 6fd1796b946c51b999b3c2c95c29be251a48833c by Jacques Bouthillier
Bug 493431 - NPE when performing a request on starred as anonymous

Change-Id: I6c5da32a95b29d2c7ff5fece22443b670d76c1d9
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/views/GerritTableView.java
Commit a2fde2f0298054880abb090e854c7c61bedf6810 by Jacques Bouthillier
Bug 491277 - Reply fails on Gerrit 2.12

Change-Id: Idefd3e6d59e734a4058b508193edc6c1c3e94d4a
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritHttpClient.java
The file was modifiedorg.eclipse.egerrit.releng/gerritServers/stopAndDeleteContainers.sh
The file was modifiedorg.eclipse.egerrit.releng/gerritServers/Docker/Dockerfile
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/Common.java
The file was modifiedorg.eclipse.egerrit.releng/gerritServers/startContainers.sh
Commit 933eb604bd6da10fc9c9e291ddae0a115a7be0a1 by Pascal Rapicault
Cleanup the code that get the auth key

Change-Id: I1488f20f661662a529f36bc032ea261e0a342733
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritHttpClient.java
Commit 824f53e98cfa17b12e80d6a65b48a082a4234872 by Pascal Rapicault
Bug 480254 - Button to cherry-pick change onto local branch.

The checkout button has been replaced by a button called download that
allows the user to trigger both the checkout and cherry-pick

Also all the code doing the checkout has been moved to a separate class.

Change-Id: Ice5d4e30b5cae9fe0c4877867d2ee13ddbca8bfd
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/001Test.test
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/CheckoutRevision.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/CherryPickRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentExtractor.java
Commit 467a12bd20450dfc8870eb70b0f792e4ecd2efed by Pascal Rapicault
Bug 492850 - In Gerrit server dialog, Enter should do OK

https://bugs.eclipse.org/bugs/show_bug.cgi?id=492850

Change-Id: Ia895ceae11f3a6fdf78c4dead571e778ebcb5c75
Signed-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com>
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritServerDialog.java