SuccessChanges

Summary

  1. Create markers for comments and drafts (details)
  2. Comment Markers changes - Cleanup and improvements (details)
  3. Bug 491618 - NullPointerException in (details)
  4. Bug 491707 - NullPointerException QueryHelpers.loadRevisionDetails (details)
  5. Fix NPE in hyperlink detector (details)
  6. Get project name from the changeInfo (details)
  7. Bug 491715 - Context menu of the files tab never goes away (details)
  8. Bug 491643 - [History tab] History empty and patchset list only has one (details)
  9. Cosmetic changes (details)
  10. Bug 491641 - [Details tab] Related changes not shown when opening a (details)
  11. Bug 491617 - Reviewer list not refreshed after reviewer removal (details)
  12. Bug 491615 - Commit and Parent info does not refresh (details)
  13. Bug 489937 - Patchset list doest not refresh when draft state of a (details)
  14. Bug 491538 - Selecting the patchset through the top right drop down does (details)
  15. Remove logging from query helper (details)
  16. Open user selected review on the right side (details)
  17. Adjust the Junit test for EGerrit (details)
  18. Stop testing adding a reviewer (details)
  19. Bug 487965 - [Compare] Allow comparison of workspace to base (details)
  20. Bug 492039 - Fix presentation of patchset in the editor toolbar (details)
  21. Bug 490009 - [Compare] Some files are not presented (details)
  22. Bug 488133 - Changing the commit message does not refresh the list of (details)
  23. Bug 490959 - Editor title not updated after commit summary changes (details)
  24. Bug 490919 - Unable to create a global comment for a file (details)
  25. Allow to Open File directly from the history file. (details)
  26. Adjust sonar cube (details)
  27. Bug 491814 - Show Marker view automatically when Activate Comment (details)
  28. Adjust path for the test (details)
  29. use maven central proxy at Eclipse (details)
  30. Bug 490794 - [Usability][History tab] Cannot resize columns of file list (details)
  31. Bug 492014 - Improve error message when ssl problems occur (details)
  32. Bug 479694 - Can't connect to self-signed servers (details)
Commit c9c9463075caae49cfbdb4715517d508c7ef1aaf by gperron
Create markers for comments and drafts

Change-Id: I29aebf72479dcf7aec47e8ab6192409d33e57afc
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixer.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/ActiveWorkspaceRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/UIUtils.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyToComment.java
The file was modifiedorg.eclipse.egerrit.dashboard.ui/META-INF/MANIFEST.MF
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/MarkerContributionFactory.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixDeleteDraftComment.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/MarkerMenuContribution.java
The file was modifiedorg.eclipse.egerrit.ui/META-INF/MANIFEST.MF
The file was modifiedorg.eclipse.egerrit.ui/plugin.xml
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixReplyDoneToComment.java
The file was modifiedorg.eclipse.egerrit.model/META-INF/MANIFEST.MF
Commit 9eeb366655da16d148af55d23425f811df8e117c by gperron
Comment Markers changes - Cleanup and improvements

Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/ActiveWorkspaceRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QuickFixer.java
Commit e5b858837db009426a6602bb1d10308959f38128 by Pascal Rapicault
Bug 491618 - NullPointerException in
ModifiedChangeInfoImpl.setUserSelectedRevision

Change-Id: I5c2e52b6604d2d27120d9494829e75f3cb2411a5
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.model/src/org/eclipse/egerrit/internal/model/ModifiedChangeInfoImpl.java
Commit 5c7bc12caa551fae945abb194f4e4ffd1c246470 by Pascal Rapicault
Bug 491707 - NullPointerException QueryHelpers.loadRevisionDetails

Change-Id: I2c089c44ad7786fd28e29d7c79cad8f465d40cc0
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/utils/ActiveWorkspaceRevision.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QueryHelpers.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
Commit a4fc990752f62f5e11c2858ba20edc08a541f86a by Pascal Rapicault
Fix NPE in hyperlink detector

Change-Id: I28280dbf7e950a3d5f9c9aec626adc3dd045b57c
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/HyperLinkDetector.java
Commit fe6ec21c01db36486128dcdde3302137f85d5d86 by Pascal Rapicault
Get project name from the changeInfo

Change-Id: I1a1cdb741c88245c0d989001d85002fffd4beb2a
Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit 433764f011cbd1f5e94ed49e08fbb4ce04a35a9e by Jacques Bouthillier
Bug 491715 - Context menu of the files tab never goes away
This occured on window environment.

Change-Id: I2d28d98308ed56e0c86a9e52e33553dbfe052a4d
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
Commit 0224dab06865546b66db95b5997bebdf4caf6c3f by Pascal Rapicault
Bug 491643 - [History tab] History empty and patchset list only has one
element after a double dashboard search

Change-Id: I9c9549e3d8d8b761fcd32edb799308d01c54fa88
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ModelLoader.java
Commit dd3b6cda7408e59db78575879b54f8cd557fe979 by Pascal Rapicault
Cosmetic changes

Change-Id: I09cb06f316c0b8764c3bd8b02b1f4da6d38aa2e4
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
Commit 0721e6adeb0aa29a3713bc9f30d671cc3df764ff by Pascal Rapicault
Bug 491641 - [Details tab] Related changes not shown when opening a
review from related changes list

Also synchronize the loading of the model

Change-Id: Ic874fad84c4133142de000ea7ff2a5dea6333056
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QueryHelpers.java
Commit 26ecc3b75ae3c5adac8f64d66cf1e0f6dae7e592 by Pascal Rapicault
Bug 491617 - Reviewer list not refreshed after reviewer removal

The problem lies in the fact that the "updated" timestamp returned by
the server side is not changed when the list of reviewer is changed.
Therefore we manually add and remove the reviewers to the model when the
action succeeds

Change-Id: I9868c3551b10682309483a31455962dcda23e224
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/SummaryTabView.java
Commit d8bf89e6b70ad907dfbb4b054c9c20bb38d2aa45 by Pascal Rapicault
Bug 491615 - Commit and Parent info does not refresh

Because the most recent revision is a derived value from the current
revision field, we need to make sure that notification is sent when the
current revision is changed.

Change-Id: I86f781fe7066f8961da490f50c9a58327baa532a
The file was modifiedorg.eclipse.egerrit.model/src/org/eclipse/egerrit/internal/model/ModifiedChangeInfoImpl.java
Commit d9d9f5f7d65a4ec81d4734ce12553d96dcf7e264 by Pascal Rapicault
Bug 489937 - Patchset list doest not refresh when draft state of a
patchset changes

Change-Id: I30e8ab59db26d97ae9fad14286d3593d6b7e9d7a
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QueryHelpers.java
Commit f58328d6ad897d934062236b376077dc6f841834 by Pascal Rapicault
Bug 491538 - Selecting the patchset through the top right drop down does
not show the list of files

Change-Id: I0043f72295378c9097f913c51d3cb48a687da59f
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ModelLoader.java
Commit 0f84606babb462fc2880295bcb40a346e011b7cf by Pascal Rapicault
Remove logging from query helper

Change-Id: Id082ea23a1344db127b23be979011be9660fbbe6
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/QueryHelpers.java
Commit 364299643c1cf0f73c525289d000d568c140b2d5 by Pascal Rapicault
Open user selected review on the right side

Change-Id: I641cfecb9d730eb6c5ab5999a96a6813685091d2
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
Commit c7f6a3f72f3543eab17724e5f56dc6a8618ee737 by Jacques Bouthillier
Adjust the Junit test for EGerrit


Change-Id: Ie5364cacc50e5d4b0373724ccf1aa93fa0c8110c
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/GerritClientAuthenticationTest.java
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A8RefreshDashboard.test
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/EditionLimiterTests.java
The file was removedorg.eclipse.egerrit.ui/target/.gitignore
The file was modifiedorg.eclipse.egerrit.updatesite/site.xml
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/B1SelectReviewerFromList.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/B0DraftReviews.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/SanityCheck.suite
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A9FileTabDisplayOrder.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/001Test.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A4Restore.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A5OverView.test
The file was modifiedorg.eclipse.egerrit.core.tests/src/org/eclipse/egerrit/core/tests/Common.java
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A1SetupVagrantServer.test
The file was modifiedorg.eclipse.egerrit.ui.tests/META-INF/MANIFEST.MF
The file was removedorg.eclipse.egerrit.ui.tests/target/.gitignore
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A3Abandon.test
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/RCPTTInitialSetOfReviews.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/UndoTest.java
The file was modifiedorg.eclipse.egerrit.ui.tests/src/org/eclipse/egerrit/ui/tests/InsertionTest.java
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/A6OpenCompareEditor.test
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/pom.xml
Commit 5484a8c4da1f2d9d02e5df9cd503d92db0781f57 by Jacques Bouthillier
Stop testing adding a reviewer

Change-Id: I7c28cc0df290f6b0466f5cc4f616f28ad2e1137e
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui.rcptt.tests/B1SelectReviewerFromList.test
Commit 7c97084f022ca751f0cfccd17e7a13717c66f4c8 by Jacques Bouthillier
Bug 487965 - [Compare] Allow comparison of workspace to base

Change-Id: Icfafee76d92e8d87b27e27916383eba8d54dcd65
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritMultipleInput.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowUnchangedFilesAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareUpperSection.java
Commit c4fe549a7e2d0f23d102735fe34a1ac6cdfceb8d by Jacques Bouthillier
Bug 492039 - Fix presentation of patchset in the editor toolbar

Change-Id: I9960cf52bbdbfcc974806769b3b780ba72b2a390
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/PatchSetHandlerProvider.java
The file was addedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/provider/SwitchCurrentPathsetAction.java
Commit d0c4c16b463fbcfd457363a3b114c15fa3fb6eb3 by Jacques Bouthillier
Bug 490009 - [Compare] Some files are not presented

Rather than diffing the list of files contained in each revision and
having to deal with the case where some files disappeared between two
revisions. We simply use the appropriate call to get the diff between
two revisions.

Because of this, we no longer need the button to filter the modified
files between two revisions

Change-Id: I4ea6a3acaafa2ce17b763ffc22955e7a8fc7f913
The file was removedorg.eclipse.egerrit.ui/icons/compare_with_other.gif
The file was removedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/ShowUnchangedFilesAction.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CompareUpperSection.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/GerritMultipleInput.java
Commit 04d6237af63f931ef33f15c25c259558e7aa7910 by Jacques Bouthillier
Bug 488133 - Changing the commit message does not refresh the list of
patchset

Change-Id: I460525ca49a56b0c913f4184c2195c39311353d7
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/tabs/MessageTabView.java
Commit e950911e2019394adc4e4b83694ac3a24688a80e by Pascal Rapicault
Bug 490959 - Editor title not updated after commit summary changes

Change-Id: I604459186fe49078b8fb45400bce197f7f54317c
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
Commit 18e05e13d5e305185410c6e059b96898c0c0f266 by Pascal Rapicault
Bug 490919 - Unable to create a global comment for a file

Change-Id: I1dc32a62b8c35253d72b3693638f6c81eb56911f
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/internal/ui/compare/CommentableCompareItem.java
Commit e47589c6a82f7fd3c192d4455160752ef82690ea by Jacques Bouthillier
Allow to Open File directly from the history file.

Change-Id: I2866bac257c26616ed787027cd6675d4134e291d
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
The file was modifiedorg.eclipse.egerrit.ui/META-INF/MANIFEST.MF
Commit 5d805851f4b52999c7d04f32509a75111716dea2 by Jacques Bouthillier
Adjust sonar cube

Change-Id: I97a47d8cfd19b9c3d1eaabcb35ff5b5511887a7b
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedpom.xml
Commit 48e830c5707297e3833a7344c0e530d5e4b5e32d by gperron
Bug 491814 - Show Marker view automatically when Activate Comment
Markers is selected

Change-Id: I2a16b8ff89a2ea70308967a40205b847fc93bc3c
Signed-off-by: gperron <guy.perron@ericsson.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/editors/ChangeDetailEditor.java
Commit 0a5f44230eb3956e382b281b60fedca2c92bdb46 by Jacques Bouthillier
Adjust path for the test

Change-Id: I786cf5ce89dff96ca1c3989a28369d904f20c549
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedpom.xml
Commit 1000d1b959945d304a9d407be40d37a5f8d44b72 by Pascal Rapicault
use maven central proxy at Eclipse

Change-Id: I90b713f759b33a980cf8c34acdacc611d8bdee11
The file was addedorg.eclipse.egerrit.releng/settings.xml
Commit 952c091cb07000fd55b757c55b9dfa826944ca77 by Jacques Bouthillier
Bug 490794 - [Usability][History tab] Cannot resize columns of file list

Change-Id: I5021c23b3e246359acb46eb7cd33d779c2079b3d
Signed-off-by: Jacques Bouthillier <lmcbout@gmail.com>
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/model/FilesTableModel.java
The file was modifiedorg.eclipse.egerrit.ui/src/org/eclipse/egerrit/ui/internal/table/UIFilesTable.java
Commit e3151534046fd429150e2630c1dca141e07439de by Pascal Rapicault
Bug 492014 - Improve error message when ssl problems occur

Change-Id: Icf63bcc5a6ca1bc11d3ccd0951cf9ce56d8fbc65
The file was modifiedorg.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/dashboard/ui/preferences/GerritServerDialog.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritRepository.java
Commit c433c850db8d1ecfe652541a0acd935fda07b720 by Pascal Rapicault
Bug 479694 - Can't connect to self-signed servers

Change-Id: Id240f0bd9a324fa4bf6f85849021e823c3d0e7bc
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritRepository.java
The file was modifiedorg.eclipse.egerrit.core/src/org/eclipse/egerrit/core/GerritHttpClient.java