SuccessChanges

Summary

  1. Bug 572600: cleanup IScriptEngine (details)
  2. Bug 572600: remove ScriptResult.getResult() (details)
  3. Bug 572600: re-add old interface methods, yet deprecated (details)
  4. Bug 522137: fix some trivial build warnings (details)
  5. Bug 522137: use IEnvironment instead of EnvironmentModule where possible (details)
  6. Bug 536451: [Py4J] provide a dedicated VOID return type (details)
  7. Bug 522137: enable spotbugs/checkstyle/pmd for unit tests (details)
Commit 8f37e67ff41f1bc91a8e3ca55b865c34171d36c4 by Christian Pontesegger
Bug 572600: cleanup IScriptEngine

  remove methods for sync/async execution as we now have a future
  scriptResult
  simplify interface for inject to 1 method

Change-Id: Idb5dab3b27be8f3aeb3461d92c18dea49d2a0e88
The file was modifiedplugins/org.eclipse.ease.lang.javascript.nashorn/src/org/eclipse/ease/lang/javascript/nashorn/NashornBootstrapper.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/JarDropHandler.java
The file was modifiedplugins/org.eclipse.ease.lang.javascript.rhino/src/org/eclipse/ease/lang/javascript/rhino/RhinoScriptEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/AbstractReplScriptEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/AbstractScriptEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/EnvironmentModule.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/view/ScriptHistoryText.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/debugging/AbstractEaseDebugger.java
The file was modifiedtests/org.eclipse.ease.lang.unittest.test/src/org/eclipse/ease/lang/unittest/ModernJavaScriptTest.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/AbstractReplScriptEngineTest.java
The file was modifiedplugins/org.eclipse.ease.lang.unittest/src-gen/org/eclipse/ease/lang/unittest/runtime/impl/TestFile.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/VariablesDropHandler.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/Py4JEngineTestBase.java
The file was modifiedplugins/org.eclipse.ease.lang.ruby.jruby/src/org/eclipse/ease/lang/ruby/jruby/JRubyEnvironementBootStrapper.java
The file was modifiedplugins/org.eclipse.ease.lang.unittest.ui/src/org/eclipse/ease/lang/unittest/ui/handlers/RunAllTests.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/AbstractModuleDropHandler.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/launching/EaseLaunchDelegate.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/EaseTestBase.java
The file was modifiedtests/org.eclipse.ease.testhelper/src/org/eclipse/ease/testhelper/AbstractDebugTest.java
The file was modifiedtests/org.eclipse.ease.testhelper/src/org/eclipse/ease/testhelper/python/AbstractPep302ModuleLoadingTest.java
The file was addedplugins/org.eclipse.ease/src/org/eclipse/ease/ScriptEngineInterruptedException.java
The file was modifiedplugins/org.eclipse.ease.ui.scripts/src/org/eclipse/ease/ui/scripts/ui/ScriptComposite.java
The file was modifiedtests/org.eclipse.ease.lang.unittest.test/src/org/eclipse/ease/lang/unittest/TestBase.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/ShellDropTarget.java
The file was modifiedtests/org.eclipse.ease.lang.unittest.test/src/org/eclipse/ease/lang/unittest/ClassicJavaScriptTest.java
The file was modifiedplugins/org.eclipse.ease.lang.python.py4j/src/org/eclipse/ease/lang/python/py4j/internal/Py4JBootstrap.java
The file was modifiedplugins/org.eclipse.ease.lang.python/src/org/eclipse/ease/lang/python/Pep302ModuleImporter.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/AbstractScriptEngineTest.java
The file was modifiedplugins/org.eclipse.ease.ui.scripts/src/org/eclipse/ease/ui/scripts/handler/RunScript.java
The file was modifiedtests/org.eclipse.ease.lang.javascript.rhino.test/src/org/eclipse/ease/lang/javascript/rhino/RhinoScriptEngineTest.java
The file was modifiedplugins/org.eclipse.ease.lang.unittest/src/org/eclipse/ease/lang/unittest/UnitTestModule.java
The file was modifiedtests/org.eclipse.ease.lang.javascript.rhino.test/src/org/eclipse/ease/lang/javascript/rhino/RhinoDebuggerEngineTest.java
The file was modifiedplugins/org.eclipse.ease.ui.scripts/src-gen/org/eclipse/ease/ui/scripts/repository/impl/ScriptImpl.java
The file was modifiedtests/org.eclipse.ease.lang.scriptarchive.test/src/org/eclipse/ease/lang/scriptarchive/ArchiveEngineTest.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/view/ScriptShell.java
The file was modifiedplugins/org.eclipse.ease.lang.python/src/org/eclipse/ease/lang/python/debugger/PythonDebugger.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/handler/LoadModule.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/ModulesDropHandler.java
The file was modifiedplugins/org.eclipse.ease.lang.groovy.interpreter/src/org/eclipse/ease/lang/groovy/interpreter/GroovyEnvironementBootStrapper.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/dnd/ResourceDropHandler.java
The file was modifiedplugins/org.eclipse.ease.lang.python.jython/src/org/eclipse/ease/lang/python/jython/PythonEnvironementBootStrapper.java
The file was addedtests/org.eclipse.ease.lang.javascript.rhino.test/src/org/eclipse/ease/lang/javascript/rhino/AbstractRhinoScriptEngineTest.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ScriptResult.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/IEnvironment.java
The file was modifiedplugins/org.eclipse.ease.lang.unittest/src-gen/org/eclipse/ease/lang/unittest/runtime/impl/TestSuite.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/BootStrapper.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/service/ScriptService.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/IReplEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/IScriptEngine.java
The file was modifiedplugins/org.eclipse.ease.lang.scriptarchive/src/org/eclipse/ease/lang/scriptarchive/ArchiveEngine.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/handler/PasteTextToScriptShell.java
The file was modifiedplugins/org.eclipse.ease.ui.scripts/src/org/eclipse/ease/ui/scripts/ui/ScriptDropHandler.java
The file was modifiedtests/org.eclipse.ease.testhelper/src/org/eclipse/ease/testhelper/AbstractEnvironmentTest.java
The file was modifiedplugins/org.eclipse.ease.lang.python/src/org/eclipse/ease/lang/python/ui/completion/PythonCompletionProviderWrapper.java
Commit eaa930a332740c7df20dfd2e55c404583bc51aac by Christian Pontesegger
Bug 572600: remove ScriptResult.getResult()

  replaced by ScriptResult.get()

Change-Id: Ib2562a41d602d1d4e6831cce81321c08f46b68b6
The file was modifiedplugins/org.eclipse.ease.lang.javascript.rhino/src/org/eclipse/ease/lang/javascript/rhino/RhinoScriptEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ScriptResult.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/Py4JEngineTestBase.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/AbstractScriptEngineTest.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/Py4JEngineTest.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/ScriptTest.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/AbstractReplScriptEngine.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ShellModeEngineTest.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/view/ScriptHistoryText.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/ScriptResultTest.java
The file was modifiedplugins/org.eclipse.ease.lang.javascript.nashorn/src/org/eclipse/ease/lang/javascript/nashorn/NashornScriptEngine.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ModeTestBase.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ScriptModeEngineTest.java
Commit 93c0b710dea39aa095b98f374daf2abfb06cf739 by Christian Pontesegger
Bug 572600: re-add old interface methods, yet deprecated

Change-Id: I34b70cfd5d2149aef51d9cdb14d836e6066c6c1f
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ModeTestBase.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/Py4JEngineTest.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ScriptModeEngineTest.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/ScriptTest.java
The file was modifiedtests/org.eclipse.ease.test/src/org/eclipse/ease/ScriptResultTest.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/Py4JEngineTestBase.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ScriptResult.java
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/src/org/eclipse/ease/lang/python/py4j/ShellModeEngineTest.java
Commit 8c9d8fc8150e78c16bb564a16815a702ed93a302 by Christian Pontesegger
Bug 522137: fix some trivial build warnings

  no functional changes

Change-Id: Ia92c444de8c0ef2d1c90f02e065e33ef814e234d
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/DelegatingJarClassLoader.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/IDebugEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/applications/ListEngines.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ScriptEngineException.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ICodeFactory.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ISecurityCheck.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/tools/ContributionTools.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/Logger.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/Script.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/AbstractScriptEngine.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ICompletionContext.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/ICodeParser.java
Commit f2f1a9e8b037644bb1599e8c1ae108ac8480def1 by Christian Pontesegger
Bug 522137: use IEnvironment instead of EnvironmentModule where possible

  try to stick to interface usage and avoid hard casts to the
  implementation

Change-Id: Ia402c0da2818d2fbb2c17b23b4c1105b86a91ff6
The file was modifiedplugins/org.eclipse.ease.lang.ruby/src/org/eclipse/ease/lang/ruby/RubyCodeFactory.java
The file was modifiedtests/org.eclipse.ease.testhelper/src/org/eclipse/ease/testhelper/AbstractEnvironmentTest.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/EnvironmentModule.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/IEnvironment.java
The file was modifiedplugins/org.eclipse.ease.lang.python/src/org/eclipse/ease/lang/python/PythonCodeFactory.java
The file was modifiedplugins/org.eclipse.ease.lang.groovy/src/org/eclipse/ease/lang/groovy/GroovyCodeFactory.java
The file was modifiedplugins/org.eclipse.ease.lang.javascript.rhino/src/org/eclipse/ease/lang/javascript/rhino/debugger/actions/ModuleFilterAction.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/completion/provider/VariablesCompletionProvider.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/views/shell/dropins/variables/HiddenVariablesFilter.java
The file was modifiedplugins/org.eclipse.ease/src/org/eclipse/ease/modules/ModuleHelper.java
The file was modifiedplugins/org.eclipse.ease.lang.javascript/src/org/eclipse/ease/lang/javascript/JavaScriptCodeFactory.java
Commit 85e98a610b0607fcc0a4b3739e8cc38737992dff by Christian Pontesegger
Bug 536451: [Py4J] provide a dedicated VOID return type

  special return type used for wrapped 'void' methods
  we still cannot suppress return values for pure python code as the API
  shows no difference between void and null values.

Change-Id: I9b0798c121229b33d162e19cbfa89f850a7332d3
The file was modifiedtests/org.eclipse.ease.lang.python.test/META-INF/MANIFEST.MF
The file was modifiedtests/org.eclipse.ease.lang.python.test/src/org/eclipse/ease/lang/python/PythonCodeFactoryTest.java
The file was modifiedplugins/org.eclipse.ease.lang.python/src/org/eclipse/ease/lang/python/PythonCodeFactory.java
The file was modifiedplugins/org.eclipse.ease.ui/src/org/eclipse/ease/ui/view/ScriptHistoryText.java
Commit 4acf080bd5033a6c1948beecc675270efa0e1ec6 by Christian Pontesegger
Bug 522137: enable spotbugs/checkstyle/pmd for unit tests

  further fix some trivial warnings

Change-Id: Ic956d53771ae37f2b1f762b5be82b0a121db5fc2
The file was modifiedtests/org.eclipse.ease.lang.scriptarchive.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedreleng/org.eclipse.ease.releng/spotbugs/spotbugs_filter_unittest.xml
The file was modifiedtests/org.eclipse.ease.lang.javascript.nashorn.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.ui.scripts.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.lang.javascript.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.lang.unittest.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedplugins/org.eclipse.ease.classloader/src/org/eclipse/ease/classloader/EaseClassLoader.java
The file was modifiedtests/org.eclipse.ease.ui.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/pom.xml
The file was modifiedtests/org.eclipse.ease.lang.javascript.rhino.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedplugins/org.eclipse.ease.lang.python.py4j/src/org/eclipse/ease/lang/python/py4j/internal/Py4jScriptEngine.java
The file was modifiedtests/org.eclipse.ease.testhelper/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.lang.python.jython.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.lang.python.py4j.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was modifiedtests/org.eclipse.ease.lang.python.test/.settings/edu.umd.cs.findbugs.core.prefs