Skip to content

Changes

Summary

  1. fix minor findings in MessageCommand(Response)Adapter, added more tests (details)
  2. some cleanup, reduce code duplication (details)
  3. Reviewed pull request #68. Applied minor improvements. (details)
  4. replaced the parboiled-java (version 1) based RQL parser with parboiled2 (details)
  5. review: fixed javadoc (details)
  6. review: removed unused variables from RqlParserBase (details)
  7. build and push docker images when a tag is created on GitHub (details)
  8. added semicolons to each command (details)
  9. fixed conditionals (details)
  10. fixed docker hub base-repo to "eclipse" + prepared docker-compose.yml (details)
  11. fixed parsing of complex rqls containing ) and , inside a string value (details)
Commit 4d47986c7faf08572e48d8d7aa312b6729e83a61 by dominik.guggemos
fix minor findings in MessageCommand(Response)Adapter, added more tests
to verify more combinations of parameters, removed
SendEmptyMessageResponse as it was not used anymore
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
The file was modified services/gateway/endpoints/src/main/java/org/eclipse/ditto/services/gateway/endpoints/HttpRequestActor.java (diff)
The file was removedsignals/commands/messages/src/test/java/org/eclipse/ditto/signals/commands/messages/SendEmptyMessageResponseTest.java
The file was modified signals/commands/messages/src/main/java/org/eclipse/ditto/signals/commands/messages/MessageCommandResponseRegistry.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/MessageCommandAdapter.java (diff)
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/MessageCommandResponseAdapterTest.java (diff)
The file was modified services/gateway/util/src/test/java/org/eclipse/ditto/services/gateway/starter/service/util/GatewayMappingStrategyTest.java (diff)
The file was removedsignals/commands/messages/src/main/java/org/eclipse/ditto/signals/commands/messages/SendEmptyMessageResponse.java
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/MessageCommandResponseAdapter.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/MessageAdaptableHelper.java (diff)
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/MessageCommandAdapterTest.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/AbstractAdapter.java (diff)
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/TestConstants.java (diff)
Commit 57cee4adba1379333370cc077e2bd89bb75c108b by dominik.guggemos
some cleanup, reduce code duplication
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/MessageCommandAdapterTest.java (diff)
Commit 1faeaeaf8f5c8c47517fbdf2855d9aba1b1216ff by juergen.fickel
Reviewed pull request #68. Applied minor improvements.
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/MessageCommandAdapter.java (diff)
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/MessageCommandAdapterTest.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/MessageAdaptableHelper.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/AbstractAdapter.java (diff)
The file was modified protocol-adapter/src/test/java/org/eclipse/ditto/protocoladapter/MessageCommandResponseAdapterTest.java (diff)
The file was modified protocol-adapter/src/main/java/org/eclipse/ditto/protocoladapter/Adapter.java (diff)
Commit 9cf2efc7d1fd9dfb7d125e4cd9230f75a6b35bfe by Thomas J??ckle
replaced the parboiled-java (version 1) based RQL parser with parboiled2
* parboiled2 doesn't need ASM and doesn't generate classes during
runtime which messed up building a release of Ditto
* rewrote RQL parser in Scala in order to use parboiled2
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/predicates/rql/PredicateRules.java
The file was modified model/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/predicates/rql/RqlPredicateParser.java (diff)
The file was modified model/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/options/rql/RqlOptionParser.java (diff)
The file was modified model/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/predicates/ast/MultiComparisonNode.java (diff)
The file was modified model/thingsearch-parser/src/test/java/org/eclipse/ditto/model/thingsearchparser/options/rql/RqlOptionsParserTest.java (diff)
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/BaseRules.java
The file was modified 3rd-dependencies/listDeps.sh (diff)
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/IntegerLiteralAction.java
The file was modified model/thingsearch-parser/pom.xml (diff)
The file was modified model/thingsearch/src/main/java/org/eclipse/ditto/model/thingsearch/SearchModelFactory.java (diff)
The file was modified bom/pom.xml (diff)
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/FloatingPointLiteral.java
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/options/rql/OptionRules.java
The file was addedmodel/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlPredicateParser.scala
The file was modified 3rd-dependencies/compile.txt (diff)
The file was addedmodel/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlOptionParser.scala
The file was removedmodel/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/RqlParserBase.java
The file was addedmodel/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlParserBase.scala
The file was modified 3rd-dependencies/test.txt (diff)
The file was modified model/thingsearch/src/main/java/org/eclipse/ditto/model/thingsearch/ImmutableSortOptionEntry.java (diff)
The file was modified model/thingsearch-parser/src/main/java/org/eclipse/ditto/model/thingsearchparser/predicates/ast/LogicalNode.java (diff)
The file was modified model/thingsearch-parser/src/test/java/org/eclipse/ditto/model/thingsearchparser/predicates/rql/RqlPredicateParserTest.java (diff)
Commit f15278e25e3c16d78a240365a6e471501319871f by Johannes Kraeher
review: fixed javadoc
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
The file was modified model/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlPredicateParser.scala (diff)
The file was modified model/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlOptionParser.scala (diff)
Commit 1e620415dc3ef772c27b479c7bc76fbee1073606 by Johannes Kraeher
review: removed unused variables from RqlParserBase
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
The file was modified model/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlParserBase.scala (diff)
Commit 89180cc0ecf4303a00efd9f66428fbce19f2e2ac by Thomas J??ckle
build and push docker images when a tag is created on GitHub
* by downloading maven artifact from Eclipse maven repo
* using the same Dockerfile for all services + build args
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was modified pom.xml (diff)
The file was removedservices/gateway/Dockerfile
The file was removedservices/policies/Dockerfile
The file was modified .travis.yml (diff)
The file was removedservices/things/Dockerfile
The file was addedservices/Dockerfile
The file was removedservices/thingsearch/Dockerfile
Commit 209bb128c3048c25e0b20cda7673049e94c19d77 by Thomas J??ckle
added semicolons to each command
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was modified .travis.yml (diff)
Commit 94af9187586e23f36db8a42fe801c3459843fa9b by Thomas J??ckle
fixed conditionals
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was modified .travis.yml (diff)
Commit 729fafefcefd499e9c18973d2bb3637ee53e27de by Thomas J??ckle
fixed docker hub base-repo to "eclipse" + prepared docker-compose.yml
for instant start of released Ditto
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was modified documentation/src/main/resources/_posts/2017-11-10-welcome-to-ditto.md (diff)
The file was addeddocker/dev.env
The file was modified documentation/src/main/resources/pages/ditto/installation-running.md (diff)
The file was modified .gitignore (diff)
The file was modified docker/docker-compose.yml (diff)
The file was modified services/pom.xml (diff)
The file was modified README.md (diff)
Commit 25bf1cf37c22c5ed20246d6da5855c8a71052881 by Thomas J??ckle
fixed parsing of complex rqls containing ) and , inside a string value
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
The file was modified model/thingsearch-parser/src/test/java/org/eclipse/ditto/model/thingsearchparser/predicates/rql/RqlPredicateParserTest.java (diff)
The file was modified model/thingsearch-parser/src/main/scala/org/eclipse/ditto/model/thingsearchparser/parser/RqlParserBase.scala (diff)