SuccessChanges

Summary

  1. Instead of null it's required to return the diagnostic acknowledgement (details)
  2. Fix published/acknowledged metrics (details)
  3. Make it possible to track successful sendings when confirmed by a 5xx (details)
  4. Allow issuing an acknowledgement that is not a live response for (details)
Commit 911b8309334d92682203659a09f6a214097f5345 by Yannic Klem
Instead of null it's required to return the diagnostic acknowledgement

* Logging and metrics of the success case is based on the returned
  command response or acknowledgement. It's required to be non null.

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherActor.java (diff)
Commit 91932981e191395b80c0753b91cde002c497f991 by Yannic Klem
Fix published/acknowledged metrics

* Live message responses are always considered as indicator for
  successful publishing of the message
* Acknowledgements with 5xx status code indicate a negative acknowledgement.
  If these acknowledgements are created out of an unhandled exception,
  it is also considered as an indicator for a failed sending of the message
* Acknowledgement with 4xx status code indicate a negative acknowledgement
  but successful sending of the message
* Acknowledgements with 2xx status code indicate a positive acknowledgement
  and successful sending of the message

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/Sending.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/SendingTest.java (diff)
Commit 80270a88682000be0cce48588f5d4e4c098cfc88 by Yannic Klem
Make it possible to track successful sendings when confirmed by a 5xx
acknowledgement

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/Sending.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/SendingTest.java (diff)
Commit ac3447360fbd03ef2b25f19049bccc156c27a2c9 by Yannic Klem
Allow issuing an acknowledgement that is not a live response for
live messages via HTTP push connection

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherActorTest.java (diff)