SuccessChanges

Summary

  1. Introduce SilentlyFailingRevocationChecker (details)
  2. Make revocation check optional at the trust-manager level. (details)
  3. make connection logger a field of BasePublisherActor (details)
  4. Make connectionLogger field in DittoTrustManager non nullable (details)
  5. Make hostname non nullable since it was only null in test cases (details)
  6. delegateWithoutRevocationCheck can never be null (details)
Commit 70d81edc709e6b7467dd51c8ccebb87bea93e1a6 by Yannic Klem
Introduce SilentlyFailingRevocationChecker

* This checker catches failures during revocation checking and logs them
  in a connection logger

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/DefaultHiveMqtt3ClientFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/amqp/AmqpClientActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/rabbitmq/ConnectionBasedRabbitConnectionFactoryFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/CustomSSLContextTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/rabbitmq/RabbitMQClientActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/validation/ConnectionValidator.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/monitoring/logs/ConnectionLogger.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/HiveMqttClientFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/AbstractHiveMqttClientFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/AbstractMqttClientActor.java (diff)
The file was addedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SilentlyFailingRevocationChecker.java
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/JmsConnectionFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/ConnectionBasedJmsConnectionFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/MockHiveMqtt3ClientFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreator.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/JMSConnectionHandlingActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/TrustManagerFactoryFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPushFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/MockHiveMqtt5ClientFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPushClientActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreatorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/AmqpClientActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/AbstractBaseClientActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherErrorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManagerFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/rabbitmq/RabbitConnectionFactoryFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPushFactoryTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/AbstractSSLContextTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/DefaultHttpPushFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPushClientActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/rabbitmq/RabbitMQClientActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/amqp/JmsConnectionHandlingActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/mqtt/hivemq/DefaultHiveMqtt5ClientFactory.java (diff)
Commit 7a4b8c43bd7174afb2e384f9903db5d0879018f6 by Yufei Cai
Make revocation check optional at the trust-manager level.

It is not possible to perform revocation check and not throw
any exception inside an PKIXRevocationCheckerbecause the
certificate validator does not initialize non-default
revocation checkers, which causes NullPointerException
on each check.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManager.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManagerFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/TrustManagerFactoryFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreator.java (diff)
The file was addedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/NoRevocationChecker.java
The file was removedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SilentlyFailingRevocationChecker.java
Commit 6af1af963d62922101bb5c3022d2d3089aad5391 by Yannic Klem
make connection logger a field of BasePublisherActor

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/BasePublisherActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/AmqpPublisherActor.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPublisherActor.java (diff)
Commit 8bf97083116b6b1364dccf5bf1e518b5b72432fa by Yannic Klem
Make connectionLogger field in DittoTrustManager non nullable

* Adapt test code to properly mock the parameter

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/CustomSSLContextTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManager.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/AbstractSSLContextTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreator.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/AbstractBaseClientActorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/validation/ConnectionValidator.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManagerFactory.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreatorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/httppush/HttpPushClientActorTest.java (diff)
Commit 05c727d6bc996a8caf18e8754d915e582772fb74 by Yannic Klem
Make hostname non nullable since it was only null in test cases

* adapted test cases to not call methods with null hostname

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManager.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/AbstractSSLContextTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/test/java/org/eclipse/ditto/services/connectivity/messaging/validation/ConnectionValidatorTest.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/SSLContextCreator.java (diff)
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManagerFactory.java (diff)
Commit b8f6489a54208f93d0f69d08595b42dd11401bc3 by Yannic Klem
delegateWithoutRevocationCheck can never be null

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modifiedservices/connectivity/messaging/src/main/java/org/eclipse/ditto/services/connectivity/messaging/internal/ssl/DittoTrustManager.java (diff)