SuccessChanges

Summary

  1. fixed that attributes and feature properties were not recursively checked for valid JSON key names (details)
  2. move error message describing a pattern mismatch to respective validator (details)
  3. added missing javadoc @throws to AttributesBuilder#build (details)
Commit cdf651c5b4e9615451ed711170588162f3b9b342 by Thomas Jaeckle
fixed that attributes and feature properties were not recursively checked for valid JSON key names
* added NoControlCharactersValidator and NoControlCharactersNoSlashesValidator as generic validators backed by a pattern, replacing AttributePatternValidator, LabelPatternValidator, FeaturePatternValidator, ResourcePatternValidator, SubjectPatternValidator which were already used for several use-cases themselves
* created new JsonKeyInvalidException as the used JsonPointerInvalidException was the wrong one: we validate Json keys, not pointers
* moved RegexPatternsTest to correct package
* fixed wrong license header years
* added javadoc with @since where missing
* added missing @throws on javadocs

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
The file was modifiedmodel/policies/src/main/java/org/eclipse/ditto/model/policies/PoliciesModelFactory.java (diff)
The file was modifiedmodel/policies/src/main/java/org/eclipse/ditto/model/policies/ImmutableLabel.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/EntityIdPatternValidator.java (diff)
The file was modifiedmodel/policies/src/main/java/org/eclipse/ditto/model/policies/ImmutableSubjectId.java (diff)
The file was removedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/AttributePatternValidator.java
The file was addedjson/src/main/java/org/eclipse/ditto/json/JsonKeyInvalidException.java
The file was addedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/NoControlCharactersNoSlashesValidator.java
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/ImmutableAttributes.java (diff)
The file was modifiedmodel/messages/src/main/java/org/eclipse/ditto/model/messages/DittoMessageSubjectValueValidator.java (diff)
The file was modifiedmodel/things/src/test/java/org/eclipse/ditto/model/things/ImmutableFeaturePropertiesTest.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/package-info.java (diff)
The file was addedmodel/base/src/test/java/org/eclipse/ditto/model/base/entity/id/RegexPatternsTest.java
The file was modifiedjson/src/main/java/org/eclipse/ditto/json/JsonPointerInvalidException.java (diff)
The file was removedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/LabelPatternValidator.java
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/id/RegexPatterns.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/AbstractPatternValidator.java (diff)
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/ImmutableFeature.java (diff)
The file was removedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/ResourcePatternValidator.java
The file was removedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/SubjectPatternValidator.java
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/ImmutableFeatureProperties.java (diff)
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/NullFeature.java (diff)
The file was addedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/NoControlCharactersValidator.java
The file was removedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/FeaturePatternValidator.java
The file was removedmodel/base/src/test/java/org/eclipse/ditto/model/base/entity/validation/RegexPatternsTest.java
The file was modifiedsignals/base/src/main/java/org/eclipse/ditto/signals/base/GlobalErrorRegistry.java (diff)
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/FeaturePropertiesBuilder.java (diff)
The file was modifiedmodel/things/src/test/java/org/eclipse/ditto/model/things/ThingsModelFactoryTest.java (diff)
The file was modifiedmodel/things/src/test/java/org/eclipse/ditto/model/things/ImmutableAttributesTest.java (diff)
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/AttributesModelFactory.java (diff)
The file was modifiedmodel/things/src/test/java/org/eclipse/ditto/model/things/ImmutableFeatureTest.java (diff)
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/ThingsModelFactory.java (diff)
The file was modifieddocumentation/src/main/resources/pages/ditto/basic-namespaces-and-names.md (diff)
The file was modifiedjson/src/main/java/org/eclipse/ditto/json/JsonObject.java (diff)
Commit 9605361a19790bad5a1fd0bb2543d8b1c5a69926 by dominik.guggemos
move error message describing a pattern mismatch to respective validator

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/id/RegexPatterns.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/AbstractPatternValidator.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/NoControlCharactersNoSlashesValidator.java (diff)
The file was modifiedmodel/base/src/test/java/org/eclipse/ditto/model/base/entity/id/RegexPatternsTest.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/EntityIdPatternValidator.java (diff)
The file was modifiedmodel/base/src/main/java/org/eclipse/ditto/model/base/entity/validation/NoControlCharactersValidator.java (diff)
Commit c7180f6665637eb68f80153032138bfac044f258 by Thomas Jaeckle
added missing javadoc @throws to AttributesBuilder#build

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
The file was modifiedmodel/things/src/main/java/org/eclipse/ditto/model/things/AttributesBuilder.java (diff)